Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't restore eventFactory after Close/Unregister #1356

Merged
merged 1 commit into from
Sep 23, 2022
Merged

Don't restore eventFactory after Close/Unregister #1356

merged 1 commit into from
Sep 23, 2022

Conversation

glazychev-art
Copy link
Contributor

@glazychev-art glazychev-art commented Sep 21, 2022 •
edited
Loading

Signed-off-by: Artem Glazychev artem.glazychev@xored.com

Description

Don't restore eventFactory in case the connection has already been closed/unregistered (it was removed from the map)
We ran into this when we started using values ​​from the passed context (for example spiffeID)

Issue link

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

@denis-tingaikin
Copy link
Member

@glazychev-art Can we add a test to cover the issue?

@glazychev-art
Don't restore eventFactory in case the connection has already been cl…
39ef892 
…osed/unregistered

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
@denis-tingaikin denis-tingaikin merged commit 5ce22c1 into networkservicemesh:main Sep 23, 2022
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Sep 23, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
47b1f94 
…k@main

PR link: networkservicemesh/sdk#1356

Commit: 5ce22c1
Author: Artem Glazychev
Date: 2022-09-23 23:06:52 +0700
Message:
  - Don't restore eventFactory in case the connection has already been closed/unregistered (#1356)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Sep 23, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2f418aa 
…k@main

PR link: networkservicemesh/sdk#1356

Commit: 5ce22c1
Author: Artem Glazychev
Date: 2022-09-23 23:06:52 +0700
Message:
  - Don't restore eventFactory in case the connection has already been closed/unregistered (#1356)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Sep 23, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
51ce298 
…k@main

PR link: networkservicemesh/sdk#1356

Commit: 5ce22c1
Author: Artem Glazychev
Date: 2022-09-23 23:06:52 +0700
Message:
  - Don't restore eventFactory in case the connection has already been closed/unregistered (#1356)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Sep 23, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
5db81d9 
…k@main

PR link: networkservicemesh/sdk#1356

Commit: 5ce22c1
Author: Artem Glazychev
Date: 2022-09-23 23:06:52 +0700
Message:
  - Don't restore eventFactory in case the connection has already been closed/unregistered (#1356)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Sep 23, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
38413ae 
…k@main

PR link: networkservicemesh/sdk#1356

Commit: 5ce22c1
Author: Artem Glazychev
Date: 2022-09-23 23:06:52 +0700
Message:
  - Don't restore eventFactory in case the connection has already been closed/unregistered (#1356)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Sep 23, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
687029e 
…k@main

PR link: networkservicemesh/sdk#1356

Commit: 5ce22c1
Author: Artem Glazychev
Date: 2022-09-23 23:06:52 +0700
Message:
  - Don't restore eventFactory in case the connection has already been closed/unregistered (#1356)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Sep 23, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c6c8df8 
…k@main

PR link: networkservicemesh/sdk#1356

Commit: 5ce22c1
Author: Artem Glazychev
Date: 2022-09-23 23:06:52 +0700
Message:
  - Don't restore eventFactory in case the connection has already been closed/unregistered (#1356)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Sep 23, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c41cdce 
…k@main

PR link: networkservicemesh/sdk#1356

Commit: 5ce22c1
Author: Artem Glazychev
Date: 2022-09-23 23:06:52 +0700
Message:
  - Don't restore eventFactory in case the connection has already been closed/unregistered (#1356)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Sep 23, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
0544d54 
…k@main

PR link: networkservicemesh/sdk#1356

Commit: 5ce22c1
Author: Artem Glazychev
Date: 2022-09-23 23:06:52 +0700
Message:
  - Don't restore eventFactory in case the connection has already been closed/unregistered (#1356)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Sep 23, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
63c89c9 
…k@main

PR link: networkservicemesh/sdk#1356

Commit: 5ce22c1
Author: Artem Glazychev
Date: 2022-09-23 23:06:52 +0700
Message:
  - Don't restore eventFactory in case the connection has already been closed/unregistered (#1356)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Sep 23, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
bc0965b 
…k@main

PR link: networkservicemesh/sdk#1356

Commit: 5ce22c1
Author: Artem Glazychev
Date: 2022-09-23 23:06:52 +0700
Message:
  - Don't restore eventFactory in case the connection has already been closed/unregistered (#1356)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Sep 23, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
76d58a5 
…k@main

PR link: networkservicemesh/sdk#1356

Commit: 5ce22c1
Author: Artem Glazychev
Date: 2022-09-23 23:06:52 +0700
Message:
  - Don't restore eventFactory in case the connection has already been closed/unregistered (#1356)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Sep 23, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 23, 2022
Merged
Merged
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Sep 23, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
3dae907 
…k@main

PR link: networkservicemesh/sdk#1356

Commit: 5ce22c1
Author: Artem Glazychev
Date: 2022-09-23 23:06:52 +0700
Message:
  - Don't restore eventFactory in case the connection has already been closed/unregistered (#1356)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot mentioned this pull request Sep 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

@edwarnicke edwarnicke Awaiting requested review from edwarnicke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glazychev-art @denis-tingaikin