Add priorityMechanisms chain element #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
| "github.com/networkservicemesh/sdk/pkg/networkservice/core/next" | ||
| ) | ||
|
|
||
| type priorityMechanismsClient struct { |
There was a problem hiding this comment.
How do we plan to use this in forwarder-vpp app?
There was a problem hiding this comment.
We add it to the forwarder's chain, for example after filtermechanisms - https://github.com/networkservicemesh/sdk-vpp/blob/main/pkg/networkservice/chains/forwarder/server.go#L152
To pass values, we will use NSM_MECHANISM_PRIORITY env that is a prioritized list ([]string) - the first value has the highest priority.
For example, if we have
- name: NSM_MECHANISM_PRIORITY
value: ipsec
this means that the mechanismPreferences order will be: { IPSec, Wireguard }
There was a problem hiding this comment.
Looks good to me.
/cc @edwarnicke
glazychev-art
force-pushed
the
prioritize_mechanism
branch
2 times, most recently
from
517f416 to
a89233e
Compare
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
glazychev-art
force-pushed
the
prioritize_mechanism
branch
from
a89233e to
d209c31
Compare
denis-tingaikin
approved these changes
Nov 24, 2022
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Dec 6, 2022
…k@main PR link: networkservicemesh/sdk#1384 Commit: 77ae7ab Author: Artem Glazychev Date: 2022-12-06 16:30:00 +0700 Message: - Add priorityMechanisms chain element (#1384) * Add priorityMechanisms chain element Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix review comments Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Dec 6, 2022
…k@main PR link: networkservicemesh/sdk#1384 Commit: 77ae7ab Author: Artem Glazychev Date: 2022-12-06 16:30:00 +0700 Message: - Add priorityMechanisms chain element (#1384) * Add priorityMechanisms chain element Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix review comments Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Dec 6, 2022
…k@main PR link: networkservicemesh/sdk#1384 Commit: 77ae7ab Author: Artem Glazychev Date: 2022-12-06 16:30:00 +0700 Message: - Add priorityMechanisms chain element (#1384) * Add priorityMechanisms chain element Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix review comments Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Dec 6, 2022
…k@main PR link: networkservicemesh/sdk#1384 Commit: 77ae7ab Author: Artem Glazychev Date: 2022-12-06 16:30:00 +0700 Message: - Add priorityMechanisms chain element (#1384) * Add priorityMechanisms chain element Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix review comments Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Dec 6, 2022
…k@main PR link: networkservicemesh/sdk#1384 Commit: 77ae7ab Author: Artem Glazychev Date: 2022-12-06 16:30:00 +0700 Message: - Add priorityMechanisms chain element (#1384) * Add priorityMechanisms chain element Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix review comments Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Dec 6, 2022
…k@main PR link: networkservicemesh/sdk#1384 Commit: 77ae7ab Author: Artem Glazychev Date: 2022-12-06 16:30:00 +0700 Message: - Add priorityMechanisms chain element (#1384) * Add priorityMechanisms chain element Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix review comments Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Dec 6, 2022
…k@main PR link: networkservicemesh/sdk#1384 Commit: 77ae7ab Author: Artem Glazychev Date: 2022-12-06 16:30:00 +0700 Message: - Add priorityMechanisms chain element (#1384) * Add priorityMechanisms chain element Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix review comments Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Dec 6, 2022
…k@main PR link: networkservicemesh/sdk#1384 Commit: 77ae7ab Author: Artem Glazychev Date: 2022-12-06 16:30:00 +0700 Message: - Add priorityMechanisms chain element (#1384) * Add priorityMechanisms chain element Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix review comments Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Dec 6, 2022
…k@main PR link: networkservicemesh/sdk#1384 Commit: 77ae7ab Author: Artem Glazychev Date: 2022-12-06 16:30:00 +0700 Message: - Add priorityMechanisms chain element (#1384) * Add priorityMechanisms chain element Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix review comments Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Dec 6, 2022
…k@main PR link: networkservicemesh/sdk#1384 Commit: 77ae7ab Author: Artem Glazychev Date: 2022-12-06 16:30:00 +0700 Message: - Add priorityMechanisms chain element (#1384) * Add priorityMechanisms chain element Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix review comments Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Dec 6, 2022
…k@main PR link: networkservicemesh/sdk#1384 Commit: 77ae7ab Author: Artem Glazychev Date: 2022-12-06 16:30:00 +0700 Message: - Add priorityMechanisms chain element (#1384) * Add priorityMechanisms chain element Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix review comments Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Dec 6, 2022
…k@main PR link: networkservicemesh/sdk#1384 Commit: 77ae7ab Author: Artem Glazychev Date: 2022-12-06 16:30:00 +0700 Message: - Add priorityMechanisms chain element (#1384) * Add priorityMechanisms chain element Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix review comments Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Dec 6, 2022
…k@main PR link: networkservicemesh/sdk#1384 Commit: 77ae7ab Author: Artem Glazychev Date: 2022-12-06 16:30:00 +0700 Message: - Add priorityMechanisms chain element (#1384) * Add priorityMechanisms chain element Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix review comments Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artem Glazychev artem.glazychev@xored.com
Description
This PR adds
priorityMechanismschain element.The input is a list of mechanisms by priority. On the Request, the chain element sorts the mechanism preferences according to these priorities.
This element will be used on the forwarder.
Issue link
networkservicemesh/sdk-vpp#638
How Has This Been Tested?
Types of changes