fix: Return backward compatibility #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
denis-tingaikin
force-pushed
the
fix-backwawrd-compatibility
branch
from
3f29408 to
8b2e552
Compare
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
edwarnicke
approved these changes
Dec 16, 2022
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Dec 16, 2022
…k@main PR link: networkservicemesh/sdk#1399 Commit: 3057cfc Author: Denis Tingaikin Date: 2022-12-17 01:35:05 +0300 Message: - fix: Return backward compatibility (#1399) * fix backward compatibility Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix import Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Dec 16, 2022
…k@main PR link: networkservicemesh/sdk#1399 Commit: 3057cfc Author: Denis Tingaikin Date: 2022-12-17 01:35:05 +0300 Message: - fix: Return backward compatibility (#1399) * fix backward compatibility Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix import Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Dec 16, 2022
…k@main PR link: networkservicemesh/sdk#1399 Commit: 3057cfc Author: Denis Tingaikin Date: 2022-12-17 01:35:05 +0300 Message: - fix: Return backward compatibility (#1399) * fix backward compatibility Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix import Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Dec 16, 2022
…k@main PR link: networkservicemesh/sdk#1399 Commit: 3057cfc Author: Denis Tingaikin Date: 2022-12-17 01:35:05 +0300 Message: - fix: Return backward compatibility (#1399) * fix backward compatibility Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix import Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Dec 16, 2022
…k@main PR link: networkservicemesh/sdk#1399 Commit: 3057cfc Author: Denis Tingaikin Date: 2022-12-17 01:35:05 +0300 Message: - fix: Return backward compatibility (#1399) * fix backward compatibility Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix import Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Dec 16, 2022
…k@main PR link: networkservicemesh/sdk#1399 Commit: 3057cfc Author: Denis Tingaikin Date: 2022-12-17 01:35:05 +0300 Message: - fix: Return backward compatibility (#1399) * fix backward compatibility Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix import Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Dec 16, 2022
…k@main PR link: networkservicemesh/sdk#1399 Commit: 3057cfc Author: Denis Tingaikin Date: 2022-12-17 01:35:05 +0300 Message: - fix: Return backward compatibility (#1399) * fix backward compatibility Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix import Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Dec 16, 2022
…k@main PR link: networkservicemesh/sdk#1399 Commit: 3057cfc Author: Denis Tingaikin Date: 2022-12-17 01:35:05 +0300 Message: - fix: Return backward compatibility (#1399) * fix backward compatibility Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix import Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Dec 16, 2022
…k@main PR link: networkservicemesh/sdk#1399 Commit: 3057cfc Author: Denis Tingaikin Date: 2022-12-17 01:35:05 +0300 Message: - fix: Return backward compatibility (#1399) * fix backward compatibility Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix import Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Dec 16, 2022
…k@main PR link: networkservicemesh/sdk#1399 Commit: 3057cfc Author: Denis Tingaikin Date: 2022-12-17 01:35:05 +0300 Message: - fix: Return backward compatibility (#1399) * fix backward compatibility Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix import Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Dec 16, 2022
…k@main PR link: networkservicemesh/sdk#1399 Commit: 3057cfc Author: Denis Tingaikin Date: 2022-12-17 01:35:05 +0300 Message: - fix: Return backward compatibility (#1399) * fix backward compatibility Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix import Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Dec 16, 2022
…k@main PR link: networkservicemesh/sdk#1399 Commit: 3057cfc Author: Denis Tingaikin Date: 2022-12-17 01:35:05 +0300 Message: - fix: Return backward compatibility (#1399) * fix backward compatibility Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix import Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Dec 16, 2022
…k@main PR link: networkservicemesh/sdk#1399 Commit: 3057cfc Author: Denis Tingaikin Date: 2022-12-17 01:35:05 +0300 Message: - fix: Return backward compatibility (#1399) * fix backward compatibility Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * fix import Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Dec 16, 2022
This was referenced Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: denis-tingaikin denis.tingajkin@xored.com
Description
We can make a private path from grpcmetadata optional.
If registry auth is enabled then OPA will fail registers/unregisters by default policies for any combinations of old/new components.
If registry auth is disabled then the private path could be invalid, but old NSM could work with any combination of old/new components.
Issue link
networkservicemesh/deployments-k8s#8187
How Has This Been Tested?
Types of changes