Add defensive code in case mechanism elements are mistakenly chain elmements #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mements
mechanisms.NewServer(map[string]networkservice.NetworkServiceServer) presumes
that the provided implementations for a mechanism *don't* chain, but simply return to it when they are done.
The probability of an implementor getting that right is basically zero, so we wrap them in a chain
to make sure that if they call next.Server(ctx).{Request/Close} they don't continue down the
chain that mechanisms.NewServer is on.
Signed-off-by: Ed Warnicke <hagbard@gmail.com>
fkautz
approved these changes
Feb 23, 2020
nsmbot
pushed a commit
that referenced
this pull request
May 14, 2022
…i@main PR link: networkservicemesh/api#140 Commit: 73abc06 Author: Denis Tingaikin Date: 2022-05-14 22:36:44 +0300 Message: - pass only ip addresses into template (#140) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mechanisms.NewServer(map[string]networkservice.NetworkServiceServer) presumes
that the provided implementations for a mechanism don't chain, but simply return to it when they are done.
The probability of an implementor getting that right is basically zero, so we wrap them in a chain
to make sure that if they call next.Server(ctx).{Request/Close} they don't continue down the
chain that mechanisms.NewServer is on.