Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interdomain funcs to vl3-dns template #1418

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Add interdomain funcs to vl3-dns template #1418

merged 1 commit into from
Feb 27, 2023

Conversation

glazychev-art
Copy link
Contributor

Signed-off-by: Artem Glazychev artem.glazychev@xored.com

Description

Interdomain template functions have been added to vl3dns.
Now we can use a DNS template like this:
{{ index .Labels \“podName\” }}.{{ target .NetworkService }}.{{ domain .NetworkService }}.

Issue link

#1414

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

@glazychev-art glazychev-art force-pushed the vl3_dns_template branch 2 times, most recently from 463cf04 to 01b255c Compare February 7, 2023 13:02
@glazychev-art glazychev-art marked this pull request as ready for review February 7, 2023 13:13
@denis-tingaikin
Copy link
Member

@glazychev-art Could you please resolve conflicts?

@codecov
Copy link

codecov bot commented Feb 20, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@bcd1eb0). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 463cf04 differs from pull request most recent head 6cc7f06. Consider uploading reports for the commit 6cc7f06 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1418   +/-   ##
=======================================
  Coverage        ?   67.67%           
=======================================
  Files           ?      267           
  Lines           ?    11619           
  Branches        ?        0           
=======================================
  Hits            ?     7863           
  Misses          ?     3251           
  Partials        ?      505

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@glazychev-art glazychev-art force-pushed the vl3_dns_template branch 2 times, most recently from f122776 to 6624d46 Compare February 20, 2023 05:35
@glazychev-art
Copy link
Contributor Author

@denis-tingaikin
Thanks, fixed

@glazychev-art
Add interdomain funcs to vl3-dns template
6cc7f06 
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
@denis-tingaikin denis-tingaikin merged commit 75f95c7 into networkservicemesh:main Feb 27, 2023
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Feb 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d6c4c7c 
…k@main

PR link: networkservicemesh/sdk#1418

Commit: 75f95c7
Author: Artem Glazychev
Date: 2023-02-27 16:49:01 +0700
Message:
  - Add interdomain funcs to vl3-dns template (#1418)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Feb 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
ced3314 
…k@main

PR link: networkservicemesh/sdk#1418

Commit: 75f95c7
Author: Artem Glazychev
Date: 2023-02-27 16:49:01 +0700
Message:
  - Add interdomain funcs to vl3-dns template (#1418)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Feb 27, 2023
Merged
Merged
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Feb 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2951a43 
…k@main

PR link: networkservicemesh/sdk#1418

Commit: 75f95c7
Author: Artem Glazychev
Date: 2023-02-27 16:49:01 +0700
Message:
  - Add interdomain funcs to vl3-dns template (#1418)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Feb 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
6a88689 
…k@main

PR link: networkservicemesh/sdk#1418

Commit: 75f95c7
Author: Artem Glazychev
Date: 2023-02-27 16:49:01 +0700
Message:
  - Add interdomain funcs to vl3-dns template (#1418)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Feb 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
475d030 
…k@main

PR link: networkservicemesh/sdk#1418

Commit: 75f95c7
Author: Artem Glazychev
Date: 2023-02-27 16:49:01 +0700
Message:
  - Add interdomain funcs to vl3-dns template (#1418)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Feb 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
0fe76cb 
…k@main

PR link: networkservicemesh/sdk#1418

Commit: 75f95c7
Author: Artem Glazychev
Date: 2023-02-27 16:49:01 +0700
Message:
  - Add interdomain funcs to vl3-dns template (#1418)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Feb 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
fff4fef 
…k@main

PR link: networkservicemesh/sdk#1418

Commit: 75f95c7
Author: Artem Glazychev
Date: 2023-02-27 16:49:01 +0700
Message:
  - Add interdomain funcs to vl3-dns template (#1418)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot mentioned this pull request Feb 27, 2023
Merged
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Feb 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
7473aa8 
…k@main

PR link: networkservicemesh/sdk#1418

Commit: 75f95c7
Author: Artem Glazychev
Date: 2023-02-27 16:49:01 +0700
Message:
  - Add interdomain funcs to vl3-dns template (#1418)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Feb 27, 2023
Merged
Merged
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Feb 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
65e530d 
…k@main

PR link: networkservicemesh/sdk#1418

Commit: 75f95c7
Author: Artem Glazychev
Date: 2023-02-27 16:49:01 +0700
Message:
  - Add interdomain funcs to vl3-dns template (#1418)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Feb 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
ac716bc 
…k@main

PR link: networkservicemesh/sdk#1418

Commit: 75f95c7
Author: Artem Glazychev
Date: 2023-02-27 16:49:01 +0700
Message:
  - Add interdomain funcs to vl3-dns template (#1418)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Feb 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d5f0fa6 
…k@main

PR link: networkservicemesh/sdk#1418

Commit: 75f95c7
Author: Artem Glazychev
Date: 2023-02-27 16:49:01 +0700
Message:
  - Add interdomain funcs to vl3-dns template (#1418)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Feb 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
e8a22b3 
…k@main

PR link: networkservicemesh/sdk#1418

Commit: 75f95c7
Author: Artem Glazychev
Date: 2023-02-27 16:49:01 +0700
Message:
  - Add interdomain funcs to vl3-dns template (#1418)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Feb 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
82f606e 
…k@main

PR link: networkservicemesh/sdk#1418

Commit: 75f95c7
Author: Artem Glazychev
Date: 2023-02-27 16:49:01 +0700
Message:
  - Add interdomain funcs to vl3-dns template (#1418)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Feb 27, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glazychev-art @denis-tingaikin