Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vl3 dns #1429

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Fix vl3 dns #1429

merged 1 commit into from
Feb 27, 2023

Conversation

wazsone
Copy link
Contributor

@wazsone wazsone commented Feb 22, 2023

Description

Issue link

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

@wazsone wazsone self-assigned this Feb 22, 2023
@codecov
Copy link

codecov bot commented Feb 22, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@bcd1eb0). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1429   +/-   ##
=======================================
  Coverage        ?   70.13%           
=======================================
  Files           ?      242           
  Lines           ?    10956           
  Branches        ?        0           
=======================================
  Hits            ?     7684           
  Misses          ?     2774           
  Partials        ?      498

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@glazychev-art
Copy link
Contributor

Issue: networkservicemesh/integration-k8s-kind#750

@wazsone wazsone force-pushed the bug/fix-vl3-dns branch 3 times, most recently from bf90542 to d8ad729 Compare February 22, 2023 17:55
glazychev-art
glazychev-art reviewed Feb 27, 2023
View reviewed changes
pkg/networkservice/connectioncontext/dnscontext/vl3dns/server.go Outdated
Comment on lines 135 to 142
ips := getSrcIPs(resp)
if len(ips) > 0 {
for _, recordName := range recordNames {
n.dnsServerRecords.Store(recordName, ips)
}

metadata.Map(ctx, false).Store(clientDNSNameKey{}, recordNames)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to paste this block after line 132 (if err == nil {)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glazychev-art thx, done

@wazsone
fix vl3 dns
11f6267 
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
@denis-tingaikin denis-tingaikin merged commit 9a7d5a4 into networkservicemesh:main Feb 27, 2023
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Feb 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
142227a 
…k@main

PR link: networkservicemesh/sdk#1429

Commit: 9a7d5a4
Author: Ruslan Bayandinov
Date: 2023-02-27 13:50:49 +0600
Message:
  - fix vl3 dns (#1429)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Feb 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d835012 
…k@main

PR link: networkservicemesh/sdk#1429

Commit: 9a7d5a4
Author: Ruslan Bayandinov
Date: 2023-02-27 13:50:49 +0600
Message:
  - fix vl3 dns (#1429)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Feb 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
307e38f 
…k@main

PR link: networkservicemesh/sdk#1429

Commit: 9a7d5a4
Author: Ruslan Bayandinov
Date: 2023-02-27 13:50:49 +0600
Message:
  - fix vl3 dns (#1429)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Feb 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
18f0890 
…k@main

PR link: networkservicemesh/sdk#1429

Commit: 9a7d5a4
Author: Ruslan Bayandinov
Date: 2023-02-27 13:50:49 +0600
Message:
  - fix vl3 dns (#1429)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Feb 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
07f897b 
…k@main

PR link: networkservicemesh/sdk#1429

Commit: 9a7d5a4
Author: Ruslan Bayandinov
Date: 2023-02-27 13:50:49 +0600
Message:
  - fix vl3 dns (#1429)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Feb 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
209bb55 
…k@main

PR link: networkservicemesh/sdk#1429

Commit: 9a7d5a4
Author: Ruslan Bayandinov
Date: 2023-02-27 13:50:49 +0600
Message:
  - fix vl3 dns (#1429)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Feb 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
680ac1b 
…k@main

PR link: networkservicemesh/sdk#1429

Commit: 9a7d5a4
Author: Ruslan Bayandinov
Date: 2023-02-27 13:50:49 +0600
Message:
  - fix vl3 dns (#1429)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Feb 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
650fa25 
…k@main

PR link: networkservicemesh/sdk#1429

Commit: 9a7d5a4
Author: Ruslan Bayandinov
Date: 2023-02-27 13:50:49 +0600
Message:
  - fix vl3 dns (#1429)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Feb 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
f03cb08 
…k@main

PR link: networkservicemesh/sdk#1429

Commit: 9a7d5a4
Author: Ruslan Bayandinov
Date: 2023-02-27 13:50:49 +0600
Message:
  - fix vl3 dns (#1429)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Feb 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
104a07f 
…k@main

PR link: networkservicemesh/sdk#1429

Commit: 9a7d5a4
Author: Ruslan Bayandinov
Date: 2023-02-27 13:50:49 +0600
Message:
  - fix vl3 dns (#1429)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Feb 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
43a88fe 
…k@main

PR link: networkservicemesh/sdk#1429

Commit: 9a7d5a4
Author: Ruslan Bayandinov
Date: 2023-02-27 13:50:49 +0600
Message:
  - fix vl3 dns (#1429)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Feb 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
5458452 
…k@main

PR link: networkservicemesh/sdk#1429

Commit: 9a7d5a4
Author: Ruslan Bayandinov
Date: 2023-02-27 13:50:49 +0600
Message:
  - fix vl3 dns (#1429)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Feb 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
718ec40 
…k@main

PR link: networkservicemesh/sdk#1429

Commit: 9a7d5a4
Author: Ruslan Bayandinov
Date: 2023-02-27 13:50:49 +0600
Message:
  - fix vl3 dns (#1429)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot mentioned this pull request Feb 27, 2023
Merged
This was referenced Feb 27, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

@glazychev-art glazychev-art glazychev-art approved these changes

Assignees

@wazsone wazsone

Labels
None yet
Projects
Release v1.8.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wazsone @glazychev-art @denis-tingaikin