Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opentelemetry fixes #1450

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Opentelemetry fixes #1450

merged 1 commit into from
Apr 27, 2023

Conversation

glazychev-art
Copy link
Contributor

@glazychev-art glazychev-art commented Apr 26, 2023 •
edited
Loading

Description

Fixes:

  1. Added opentelemetry TextMapPropagator to link spans of different applications
  2. Added human-readable root span title
  3. Refreshes are displayed in separate spans

Jaeger output example (from the client):
jaeger

Issue link

#1441

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

@codecov
Copy link

codecov bot commented Apr 26, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@d93d939). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1450   +/-   ##
=======================================
  Coverage        ?   70.21%           
=======================================
  Files           ?      242           
  Lines           ?    11014           
  Branches        ?        0           
=======================================
  Hits            ?     7733           
  Misses          ?     2782           
  Partials        ?      499

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@glazychev-art glazychev-art changed the title Opentelementry fixes Opentelemetry fixes Apr 26, 2023
@glazychev-art
opentelemetry fixes
b132aed 
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
@glazychev-art glazychev-art marked this pull request as ready for review April 26, 2023 09:09
@denis-tingaikin denis-tingaikin requested review from denis-tingaikin and NikitaSkrynnik and removed request for denis-tingaikin April 26, 2023 10:51
@denis-tingaikin denis-tingaikin merged commit fbf0404 into networkservicemesh:main Apr 27, 2023
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Apr 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
5cd8645 
…k@main

PR link: networkservicemesh/sdk#1450

Commit: fbf0404
Author: Artem Glazychev
Date: 2023-04-27 16:14:55 +0700
Message:
  - opentelemetry fixes (#1450)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Apr 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
687546b 
…k@main

PR link: networkservicemesh/sdk#1450

Commit: fbf0404
Author: Artem Glazychev
Date: 2023-04-27 16:14:55 +0700
Message:
  - opentelemetry fixes (#1450)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Apr 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
6960687 
…k@main

PR link: networkservicemesh/sdk#1450

Commit: fbf0404
Author: Artem Glazychev
Date: 2023-04-27 16:14:55 +0700
Message:
  - opentelemetry fixes (#1450)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Apr 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
dc239cf 
…k@main

PR link: networkservicemesh/sdk#1450

Commit: fbf0404
Author: Artem Glazychev
Date: 2023-04-27 16:14:55 +0700
Message:
  - opentelemetry fixes (#1450)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Apr 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
a6637b2 
…k@main

PR link: networkservicemesh/sdk#1450

Commit: fbf0404
Author: Artem Glazychev
Date: 2023-04-27 16:14:55 +0700
Message:
  - opentelemetry fixes (#1450)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Apr 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
f2b9e77 
…k@main

PR link: networkservicemesh/sdk#1450

Commit: fbf0404
Author: Artem Glazychev
Date: 2023-04-27 16:14:55 +0700
Message:
  - opentelemetry fixes (#1450)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Apr 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2e75899 
…k@main

PR link: networkservicemesh/sdk#1450

Commit: fbf0404
Author: Artem Glazychev
Date: 2023-04-27 16:14:55 +0700
Message:
  - opentelemetry fixes (#1450)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Apr 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
f503f01 
…k@main

PR link: networkservicemesh/sdk#1450

Commit: fbf0404
Author: Artem Glazychev
Date: 2023-04-27 16:14:55 +0700
Message:
  - opentelemetry fixes (#1450)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Apr 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
5168baa 
…k@main

PR link: networkservicemesh/sdk#1450

Commit: fbf0404
Author: Artem Glazychev
Date: 2023-04-27 16:14:55 +0700
Message:
  - opentelemetry fixes (#1450)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Apr 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
02a811e 
…k@main

PR link: networkservicemesh/sdk#1450

Commit: fbf0404
Author: Artem Glazychev
Date: 2023-04-27 16:14:55 +0700
Message:
  - opentelemetry fixes (#1450)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Apr 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2475bdb 
…k@main

PR link: networkservicemesh/sdk#1450

Commit: fbf0404
Author: Artem Glazychev
Date: 2023-04-27 16:14:55 +0700
Message:
  - opentelemetry fixes (#1450)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Apr 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
8ead103 
…k@main

PR link: networkservicemesh/sdk#1450

Commit: fbf0404
Author: Artem Glazychev
Date: 2023-04-27 16:14:55 +0700
Message:
  - opentelemetry fixes (#1450)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Apr 27, 2023
Merged
Merged
Merged
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Apr 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
15190a1 
…k@main

PR link: networkservicemesh/sdk#1450

Commit: fbf0404
Author: Artem Glazychev
Date: 2023-04-27 16:14:55 +0700
Message:
  - opentelemetry fixes (#1450)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot mentioned this pull request Apr 27, 2023
Merged
This was referenced Apr 27, 2023
Merged
Merged
Closed
Merged
Merged
Merged
denis-tingaikin pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Apr 27, 2023
@glazychev-art
Fix logging (#596)
4c7cdb7 
* Update go.mod and go.sum to latest version from networkservicemesh/sdk@main
PR link: networkservicemesh/sdk#1450

Commit: fbf0404
Author: Artem Glazychev
Date: 2023-04-27 16:14:55 +0700
Message:
  - opentelemetry fixes (#1450)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>

* Fix logging

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Apr 27, 2023
Update go.mod and go.sum to latest version from networkservicemesh/cm…
46f896f 
…d-nsmgr@main

PR link: networkservicemesh/cmd-nsmgr#596

Commit: 4c7cdb7
Author: Artem Glazychev
Date: 2023-04-27 20:54:51 +0700
Message:
  - Fix logging (#596)
* Update go.mod and go.sum to latest version from networkservicemesh/sdk@main
PR link: networkservicemesh/sdk#1450

Commit: fbf0404
Author: Artem Glazychev
Date: 2023-04-27 16:14:55 +0700
Message:
    - opentelemetry fixes (#1450)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>

* Fix logging

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot mentioned this pull request Apr 27, 2023
Merged
@glazychev-art glazychev-art mentioned this pull request May 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

@NikitaSkrynnik NikitaSkrynnik NikitaSkrynnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glazychev-art @denis-tingaikin @NikitaSkrynnik