Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default_svid_ttl config removed #1458

Merged
merged 1 commit into from
May 18, 2023
Merged

default_svid_ttl config removed #1458

merged 1 commit into from
May 18, 2023

Conversation

szvincze
Copy link
Contributor

Description

Removed default_svid_ttl configuration parameter since it was renamed in SPIRE 1.6 and the default value (1h) is used anyway. This change enables to update the Dockerfiles (see below) gradually with the new SPIRE version, no need to change all of them at once, because the default value is the same for both versions however the name of the configurable changed.

ADD https://github.com/spiffe/spire/releases/download/v1.6.1/spire-1.6.1-linux-x86_64-glibc.tar.gz .
RUN tar xzvf spire-1.6.1-linux-x86_64-glibc.tar.gz -C /bin --strip=2 spire-1.6.1/bin/spire-server spire-1.6.1/bin/spire-agent

Issue link

Connected to #8963.

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

@szvincze
default_svid_ttl removed
74c61a2 
Signed-off-by: Szilard Vincze <szilard.vincze@est.tech>
denis-tingaikin
denis-tingaikin approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Befre we merge it, i tihnk it requires check a strategy to update Dockerfiles.

@d-uzlov Could you have a look?

@szvincze
Copy link
Contributor Author

Befre we merge it, i tihnk it requires check a strategy to update Dockerfiles.

@denis-tingaikin, No need to wait because the change makes it compatible with the new SPIRE version but keeps compatibility to the old version too. So, the Dockerfile update can come later without any problem.

@denis-tingaikin
Copy link
Member

@szvincze Thanks!

@denis-tingaikin denis-tingaikin merged commit ad70c1f into networkservicemesh:main May 18, 2023
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request May 18, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
ee3e65d 
…k@main

PR link: networkservicemesh/sdk#1458

Commit: ad70c1f
Author: Szilárd Vincze
Date: 2023-05-18 15:28:31 +0200
Message:
  - default_svid_ttl removed (#1458)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request May 18, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
3acc68d 
…k@main

PR link: networkservicemesh/sdk#1458

Commit: ad70c1f
Author: Szilárd Vincze
Date: 2023-05-18 15:28:31 +0200
Message:
  - default_svid_ttl removed (#1458)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request May 18, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d9eeba7 
…k@main

PR link: networkservicemesh/sdk#1458

Commit: ad70c1f
Author: Szilárd Vincze
Date: 2023-05-18 15:28:31 +0200
Message:
  - default_svid_ttl removed (#1458)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request May 18, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
35e8368 
…k@main

PR link: networkservicemesh/sdk#1458

Commit: ad70c1f
Author: Szilárd Vincze
Date: 2023-05-18 15:28:31 +0200
Message:
  - default_svid_ttl removed (#1458)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request May 18, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
61c42f2 
…k@main

PR link: networkservicemesh/sdk#1458

Commit: ad70c1f
Author: Szilárd Vincze
Date: 2023-05-18 15:28:31 +0200
Message:
  - default_svid_ttl removed (#1458)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request May 18, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
933c62c 
…k@main

PR link: networkservicemesh/sdk#1458

Commit: ad70c1f
Author: Szilárd Vincze
Date: 2023-05-18 15:28:31 +0200
Message:
  - default_svid_ttl removed (#1458)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request May 18, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
daec8a1 
…k@main

PR link: networkservicemesh/sdk#1458

Commit: ad70c1f
Author: Szilárd Vincze
Date: 2023-05-18 15:28:31 +0200
Message:
  - default_svid_ttl removed (#1458)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request May 18, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
46e8c2e 
…k@main

PR link: networkservicemesh/sdk#1458

Commit: ad70c1f
Author: Szilárd Vincze
Date: 2023-05-18 15:28:31 +0200
Message:
  - default_svid_ttl removed (#1458)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request May 18, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
ff3027a 
…k@main

PR link: networkservicemesh/sdk#1458

Commit: ad70c1f
Author: Szilárd Vincze
Date: 2023-05-18 15:28:31 +0200
Message:
  - default_svid_ttl removed (#1458)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request May 18, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
a03ea26 
…k@main

PR link: networkservicemesh/sdk#1458

Commit: ad70c1f
Author: Szilárd Vincze
Date: 2023-05-18 15:28:31 +0200
Message:
  - default_svid_ttl removed (#1458)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request May 18, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
e8385d4 
…k@main

PR link: networkservicemesh/sdk#1458

Commit: ad70c1f
Author: Szilárd Vincze
Date: 2023-05-18 15:28:31 +0200
Message:
  - default_svid_ttl removed (#1458)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request May 18, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
3c65fa2 
…k@main

PR link: networkservicemesh/sdk#1458

Commit: ad70c1f
Author: Szilárd Vincze
Date: 2023-05-18 15:28:31 +0200
Message:
  - default_svid_ttl removed (#1458)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request May 18, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
bb321a7 
…k@main

PR link: networkservicemesh/sdk#1458

Commit: ad70c1f
Author: Szilárd Vincze
Date: 2023-05-18 15:28:31 +0200
Message:
  - default_svid_ttl removed (#1458)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced May 18, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@szvincze szvincze deleted the spire-uplift branch May 18, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

@d-uzlov d-uzlov d-uzlov approved these changes

Assignees

@d-uzlov d-uzlov

Labels
None yet
Projects
Release v1.10.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@szvincze @denis-tingaikin @d-uzlov