Fix authorizeClient on failed refresh #1558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1558 +/- ##
=======================================
Coverage ? 67.27%
=======================================
Files ? 260
Lines ? 12332
Branches ? 0
=======================================
Hits ? 8296
Misses ? 3515
Partials ? 521 ☔ View full report in Codecov by Sentry. |
glazychev-art
force-pushed
the
fix_auth_client
branch
from
e3a83f6 to
5496923
Compare
NikitaSkrynnik
approved these changes
Nov 22, 2023
denis-tingaikin
approved these changes
Nov 24, 2023
|
@glazychev-art Should we also update registry chain? |
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
glazychev-art
force-pushed
the
fix_auth_client
branch
from
5496923 to
b528f40
Compare
|
@denis-tingaikin |
denis-tingaikin
approved these changes
Dec 7, 2023
nsmbot
pushed a commit
to networkservicemesh/cmd-csi-driver
that referenced
this pull request
Dec 7, 2023
…k@main PR link: networkservicemesh/sdk#1558 Commit: 774304c Author: Artem Glazychev Date: 2023-12-07 22:14:43 +0700 Message: - Fix authorizeClient on failed refresh (#1558) * Fix authorizeClient on failed refresh Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix registry Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Dec 7, 2023
…k@main PR link: networkservicemesh/sdk#1558 Commit: 774304c Author: Artem Glazychev Date: 2023-12-07 22:14:43 +0700 Message: - Fix authorizeClient on failed refresh (#1558) * Fix authorizeClient on failed refresh Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix registry Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Dec 7, 2023
…k@main PR link: networkservicemesh/sdk#1558 Commit: 774304c Author: Artem Glazychev Date: 2023-12-07 22:14:43 +0700 Message: - Fix authorizeClient on failed refresh (#1558) * Fix authorizeClient on failed refresh Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix registry Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Dec 7, 2023
…k@main PR link: networkservicemesh/sdk#1558 Commit: 774304c Author: Artem Glazychev Date: 2023-12-07 22:14:43 +0700 Message: - Fix authorizeClient on failed refresh (#1558) * Fix authorizeClient on failed refresh Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix registry Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Dec 7, 2023
…k@main PR link: networkservicemesh/sdk#1558 Commit: 774304c Author: Artem Glazychev Date: 2023-12-07 22:14:43 +0700 Message: - Fix authorizeClient on failed refresh (#1558) * Fix authorizeClient on failed refresh Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix registry Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Dec 7, 2023
…k@main PR link: networkservicemesh/sdk#1558 Commit: 774304c Author: Artem Glazychev Date: 2023-12-07 22:14:43 +0700 Message: - Fix authorizeClient on failed refresh (#1558) * Fix authorizeClient on failed refresh Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix registry Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Dec 7, 2023
…k@main PR link: networkservicemesh/sdk#1558 Commit: 774304c Author: Artem Glazychev Date: 2023-12-07 22:14:43 +0700 Message: - Fix authorizeClient on failed refresh (#1558) * Fix authorizeClient on failed refresh Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix registry Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Dec 7, 2023
…k@main PR link: networkservicemesh/sdk#1558 Commit: 774304c Author: Artem Glazychev Date: 2023-12-07 22:14:43 +0700 Message: - Fix authorizeClient on failed refresh (#1558) * Fix authorizeClient on failed refresh Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix registry Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Dec 7, 2023
…k@main PR link: networkservicemesh/sdk#1558 Commit: 774304c Author: Artem Glazychev Date: 2023-12-07 22:14:43 +0700 Message: - Fix authorizeClient on failed refresh (#1558) * Fix authorizeClient on failed refresh Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix registry Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Dec 7, 2023
…k@main PR link: networkservicemesh/sdk#1558 Commit: 774304c Author: Artem Glazychev Date: 2023-12-07 22:14:43 +0700 Message: - Fix authorizeClient on failed refresh (#1558) * Fix authorizeClient on failed refresh Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix registry Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Dec 7, 2023
…k@main PR link: networkservicemesh/sdk#1558 Commit: 774304c Author: Artem Glazychev Date: 2023-12-07 22:14:43 +0700 Message: - Fix authorizeClient on failed refresh (#1558) * Fix authorizeClient on failed refresh Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix registry Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Dec 7, 2023
…k@main PR link: networkservicemesh/sdk#1558 Commit: 774304c Author: Artem Glazychev Date: 2023-12-07 22:14:43 +0700 Message: - Fix authorizeClient on failed refresh (#1558) * Fix authorizeClient on failed refresh Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix registry Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Dec 7, 2023
…k@main PR link: networkservicemesh/sdk#1558 Commit: 774304c Author: Artem Glazychev Date: 2023-12-07 22:14:43 +0700 Message: - Fix authorizeClient on failed refresh (#1558) * Fix authorizeClient on failed refresh Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix registry Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Dec 7, 2023
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Dec 7, 2023
…k@main PR link: networkservicemesh/sdk#1558 Commit: 774304c Author: Artem Glazychev Date: 2023-12-07 22:14:43 +0700 Message: - Fix authorizeClient on failed refresh (#1558) * Fix authorizeClient on failed refresh Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Fix registry Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The main idea is not to close the existing connection during refresh in case of an error.
This corrects the situation where the spire certificate update occurred during the Request. This may return a false negative result
Issue link
networkservicemesh/deployments-k8s#10377
How Has This Been Tested?
Types of changes