-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TestRecvfdClosesSingleFile #1559
Merged
denis-tingaikin
merged 4 commits into
networkservicemesh:main
from
NikitaSkrynnik:fix-unstable-test
Dec 26, 2023
Merged
Fix TestRecvfdClosesSingleFile #1559
denis-tingaikin
merged 4 commits into
networkservicemesh:main
from
NikitaSkrynnik:fix-unstable-test
Dec 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
746e652
to
a8f0738
Compare
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
a8f0738
to
a7cab25
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1559 +/- ##
=======================================
Coverage ? 66.91%
=======================================
Files ? 259
Lines ? 12327
Branches ? 0
=======================================
Hits ? 8248
Misses ? 3560
Partials ? 519 ☔ View full report in Codecov by Sentry. |
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
denis-tingaikin
approved these changes
Nov 22, 2023
nsmbot
pushed a commit
to networkservicemesh/cmd-csi-driver
that referenced
this pull request
Dec 26, 2023
…k@main PR link: networkservicemesh/sdk#1559 Commit: 9c02db4 Author: Nikita Skrynnik Date: 2023-12-26 18:56:04 +1100 Message: - Fix TestRecvfdClosesSingleFile (#1559) * Fix TestRecvfdClosesSingleFile Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * run test 5000 times Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * add begin server + cleanup Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Dec 26, 2023
…k@main PR link: networkservicemesh/sdk#1559 Commit: 9c02db4 Author: Nikita Skrynnik Date: 2023-12-26 18:56:04 +1100 Message: - Fix TestRecvfdClosesSingleFile (#1559) * Fix TestRecvfdClosesSingleFile Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * run test 5000 times Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * add begin server + cleanup Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Dec 26, 2023
…k@main PR link: networkservicemesh/sdk#1559 Commit: 9c02db4 Author: Nikita Skrynnik Date: 2023-12-26 18:56:04 +1100 Message: - Fix TestRecvfdClosesSingleFile (#1559) * Fix TestRecvfdClosesSingleFile Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * run test 5000 times Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * add begin server + cleanup Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Dec 26, 2023
…k@main PR link: networkservicemesh/sdk#1559 Commit: 9c02db4 Author: Nikita Skrynnik Date: 2023-12-26 18:56:04 +1100 Message: - Fix TestRecvfdClosesSingleFile (#1559) * Fix TestRecvfdClosesSingleFile Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * run test 5000 times Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * add begin server + cleanup Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Dec 26, 2023
…k@main PR link: networkservicemesh/sdk#1559 Commit: 9c02db4 Author: Nikita Skrynnik Date: 2023-12-26 18:56:04 +1100 Message: - Fix TestRecvfdClosesSingleFile (#1559) * Fix TestRecvfdClosesSingleFile Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * run test 5000 times Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * add begin server + cleanup Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Dec 26, 2023
…k@main PR link: networkservicemesh/sdk#1559 Commit: 9c02db4 Author: Nikita Skrynnik Date: 2023-12-26 18:56:04 +1100 Message: - Fix TestRecvfdClosesSingleFile (#1559) * Fix TestRecvfdClosesSingleFile Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * run test 5000 times Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * add begin server + cleanup Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Dec 26, 2023
…k@main PR link: networkservicemesh/sdk#1559 Commit: 9c02db4 Author: Nikita Skrynnik Date: 2023-12-26 18:56:04 +1100 Message: - Fix TestRecvfdClosesSingleFile (#1559) * Fix TestRecvfdClosesSingleFile Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * run test 5000 times Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * add begin server + cleanup Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Dec 26, 2023
…k@main PR link: networkservicemesh/sdk#1559 Commit: 9c02db4 Author: Nikita Skrynnik Date: 2023-12-26 18:56:04 +1100 Message: - Fix TestRecvfdClosesSingleFile (#1559) * Fix TestRecvfdClosesSingleFile Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * run test 5000 times Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * add begin server + cleanup Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Dec 26, 2023
…k@main PR link: networkservicemesh/sdk#1559 Commit: 9c02db4 Author: Nikita Skrynnik Date: 2023-12-26 18:56:04 +1100 Message: - Fix TestRecvfdClosesSingleFile (#1559) * Fix TestRecvfdClosesSingleFile Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * run test 5000 times Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * add begin server + cleanup Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Dec 26, 2023
…k@main PR link: networkservicemesh/sdk#1559 Commit: 9c02db4 Author: Nikita Skrynnik Date: 2023-12-26 18:56:04 +1100 Message: - Fix TestRecvfdClosesSingleFile (#1559) * Fix TestRecvfdClosesSingleFile Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * run test 5000 times Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * add begin server + cleanup Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Dec 26, 2023
…k@main PR link: networkservicemesh/sdk#1559 Commit: 9c02db4 Author: Nikita Skrynnik Date: 2023-12-26 18:56:04 +1100 Message: - Fix TestRecvfdClosesSingleFile (#1559) * Fix TestRecvfdClosesSingleFile Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * run test 5000 times Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * add begin server + cleanup Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Dec 26, 2023
…k@main PR link: networkservicemesh/sdk#1559 Commit: 9c02db4 Author: Nikita Skrynnik Date: 2023-12-26 18:56:04 +1100 Message: - Fix TestRecvfdClosesSingleFile (#1559) * Fix TestRecvfdClosesSingleFile Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * run test 5000 times Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * add begin server + cleanup Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Dec 26, 2023
…k@main PR link: networkservicemesh/sdk#1559 Commit: 9c02db4 Author: Nikita Skrynnik Date: 2023-12-26 18:56:04 +1100 Message: - Fix TestRecvfdClosesSingleFile (#1559) * Fix TestRecvfdClosesSingleFile Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * run test 5000 times Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * add begin server + cleanup Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Dec 26, 2023
…k@main PR link: networkservicemesh/sdk#1559 Commit: 9c02db4 Author: Nikita Skrynnik Date: 2023-12-26 18:56:04 +1100 Message: - Fix TestRecvfdClosesSingleFile (#1559) * Fix TestRecvfdClosesSingleFile Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * run test 5000 times Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * add begin server + cleanup Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Dec 30, 2023
…k@main PR link: networkservicemesh/sdk#1559 Commit: 9c02db4 Author: Nikita Skrynnik Date: 2023-12-26 18:56:04 +1100 Message: - Fix TestRecvfdClosesSingleFile (#1559) * Fix TestRecvfdClosesSingleFile Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * run test 5000 times Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * add begin server + cleanup Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
#1525
How Has This Been Tested?
Types of changes