Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle INITIAL_STATE_TRANSFER only if connection state was changed #1570

Merged
merged 1 commit into from
Dec 25, 2023
Merged

Handle INITIAL_STATE_TRANSFER only if connection state was changed #1570

merged 1 commit into from
Dec 25, 2023

Conversation

glazychev-art
Copy link
Contributor

@glazychev-art glazychev-art commented Dec 22, 2023 •
edited
Loading

Description

Issue link

Closes: #1569

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

@codecov Codecov
Copy link

codecov bot commented Dec 22, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@565471f). Click here to learn what that means.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1570   +/-   ##
=======================================
  Coverage        ?   67.22%           
=======================================
  Files           ?      260           
  Lines           ?    12340           
  Branches        ?        0           
=======================================
  Hits            ?     8295           
  Misses          ?     3523           
  Partials        ?      522

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glazychev-art
Handle INITIAL_STATE_TRANSFER only if connection state was changed
cd42fe2 
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
@glazychev-art glazychev-art marked this pull request as ready for review December 22, 2023 13:13
@glazychev-art glazychev-art self-assigned this Dec 25, 2023
@denis-tingaikin denis-tingaikin merged commit 429d553 into networkservicemesh:main Dec 25, 2023
17 checks passed
nsmbot pushed a commit to networkservicemesh/cmd-csi-driver that referenced this pull request Dec 25, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
ecdcc6c 
…k@main

PR link: networkservicemesh/sdk#1570

Commit: 429d553
Author: Artem Glazychev
Date: 2023-12-25 18:00:34 +0700
Message:
  - Handle INITIAL_STATE_TRANSFER only if connection state was changed (#1570)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Dec 25, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
b5db082 
…k@main

PR link: networkservicemesh/sdk#1570

Commit: 429d553
Author: Artem Glazychev
Date: 2023-12-25 18:00:34 +0700
Message:
  - Handle INITIAL_STATE_TRANSFER only if connection state was changed (#1570)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Dec 25, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
e56e763 
…k@main

PR link: networkservicemesh/sdk#1570

Commit: 429d553
Author: Artem Glazychev
Date: 2023-12-25 18:00:34 +0700
Message:
  - Handle INITIAL_STATE_TRANSFER only if connection state was changed (#1570)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Dec 25, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
da993c2 
…k@main

PR link: networkservicemesh/sdk#1570

Commit: 429d553
Author: Artem Glazychev
Date: 2023-12-25 18:00:34 +0700
Message:
  - Handle INITIAL_STATE_TRANSFER only if connection state was changed (#1570)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Dec 25, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
4795ba9 
…k@main

PR link: networkservicemesh/sdk#1570

Commit: 429d553
Author: Artem Glazychev
Date: 2023-12-25 18:00:34 +0700
Message:
  - Handle INITIAL_STATE_TRANSFER only if connection state was changed (#1570)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Dec 25, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
b46cb77 
…k@main

PR link: networkservicemesh/sdk#1570

Commit: 429d553
Author: Artem Glazychev
Date: 2023-12-25 18:00:34 +0700
Message:
  - Handle INITIAL_STATE_TRANSFER only if connection state was changed (#1570)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Dec 25, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
905458f 
…k@main

PR link: networkservicemesh/sdk#1570

Commit: 429d553
Author: Artem Glazychev
Date: 2023-12-25 18:00:34 +0700
Message:
  - Handle INITIAL_STATE_TRANSFER only if connection state was changed (#1570)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Dec 25, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
280b1e2 
…k@main

PR link: networkservicemesh/sdk#1570

Commit: 429d553
Author: Artem Glazychev
Date: 2023-12-25 18:00:34 +0700
Message:
  - Handle INITIAL_STATE_TRANSFER only if connection state was changed (#1570)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Dec 25, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
1787a4f 
…k@main

PR link: networkservicemesh/sdk#1570

Commit: 429d553
Author: Artem Glazychev
Date: 2023-12-25 18:00:34 +0700
Message:
  - Handle INITIAL_STATE_TRANSFER only if connection state was changed (#1570)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Dec 25, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
62369c7 
…k@main

PR link: networkservicemesh/sdk#1570

Commit: 429d553
Author: Artem Glazychev
Date: 2023-12-25 18:00:34 +0700
Message:
  - Handle INITIAL_STATE_TRANSFER only if connection state was changed (#1570)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Dec 25, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
6255b39 
…k@main

PR link: networkservicemesh/sdk#1570

Commit: 429d553
Author: Artem Glazychev
Date: 2023-12-25 18:00:34 +0700
Message:
  - Handle INITIAL_STATE_TRANSFER only if connection state was changed (#1570)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Dec 25, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
9317da5 
…k@main

PR link: networkservicemesh/sdk#1570

Commit: 429d553
Author: Artem Glazychev
Date: 2023-12-25 18:00:34 +0700
Message:
  - Handle INITIAL_STATE_TRANSFER only if connection state was changed (#1570)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Dec 25, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
88c61e7 
…k@main

PR link: networkservicemesh/sdk#1570

Commit: 429d553
Author: Artem Glazychev
Date: 2023-12-25 18:00:34 +0700
Message:
  - Handle INITIAL_STATE_TRANSFER only if connection state was changed (#1570)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Dec 25, 2023
Merged
Merged
Merged
Merged
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Dec 25, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
84a3085 
…k@main

PR link: networkservicemesh/sdk#1570

Commit: 429d553
Author: Artem Glazychev
Date: 2023-12-25 18:00:34 +0700
Message:
  - Handle INITIAL_STATE_TRANSFER only if connection state was changed (#1570)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Dec 25, 2023
Merged
Merged
This was referenced Dec 25, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

Assignees

@glazychev-art glazychev-art

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MonitorConnections event overwrites previous valid connection
2 participants
@glazychev-art @denis-tingaikin