Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move registry expiration handling from updatepath to expire #1606

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Move registry expiration handling from updatepath to expire #1606

merged 1 commit into from
Apr 2, 2024

Conversation

glazychev-art
Copy link
Contributor

@glazychev-art glazychev-art commented Apr 2, 2024 •
edited
Loading

Description

Expiration logic should be in the expire chain element

Issue link

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

@glazychev-art
Move registry expiration handling from updatepath to expire
1aa9d31 
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
@codecov Codecov
Copy link

codecov bot commented Apr 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 79.48718% with 8 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@d6d5c0d). Click here to learn what that means.

Files Patch % Lines
pkg/registry/common/updatepath/context.go 28.57% 5 Missing ⚠️
pkg/registry/common/expire/nse_server.go 90.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1606   +/-   ##
=======================================
  Coverage        ?   67.45%           
=======================================
  Files           ?      263           
  Lines           ?    12493           
  Branches        ?        0           
=======================================
  Hits            ?     8427           
  Misses          ?     3539           
  Partials        ?      527

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glazychev-art glazychev-art marked this pull request as ready for review April 2, 2024 09:29
@denis-tingaikin denis-tingaikin merged commit f0105d6 into networkservicemesh:main Apr 2, 2024
17 checks passed
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Apr 2, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
0f574b0 
…k@main

PR link: networkservicemesh/sdk#1606

Commit: f0105d6
Author: Artem Glazychev
Date: 2024-04-02 16:48:55 +0700
Message:
  - Move registry expiration handling from updatepath to expire (#1606)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-csi-driver that referenced this pull request Apr 2, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
065e3d8 
…k@main

PR link: networkservicemesh/sdk#1606

Commit: f0105d6
Author: Artem Glazychev
Date: 2024-04-02 16:48:55 +0700
Message:
  - Move registry expiration handling from updatepath to expire (#1606)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-dashboard-backend that referenced this pull request Apr 2, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
35caf46 
…k@main

PR link: networkservicemesh/sdk#1606

Commit: f0105d6
Author: Artem Glazychev
Date: 2024-04-02 16:48:55 +0700
Message:
  - Move registry expiration handling from updatepath to expire (#1606)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Apr 2, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
cdfd222 
…k@main

PR link: networkservicemesh/sdk#1606

Commit: f0105d6
Author: Artem Glazychev
Date: 2024-04-02 16:48:55 +0700
Message:
  - Move registry expiration handling from updatepath to expire (#1606)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Apr 2, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
94d2fae 
…k@main

PR link: networkservicemesh/sdk#1606

Commit: f0105d6
Author: Artem Glazychev
Date: 2024-04-02 16:48:55 +0700
Message:
  - Move registry expiration handling from updatepath to expire (#1606)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Apr 2, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
0c4784b 
…k@main

PR link: networkservicemesh/sdk#1606

Commit: f0105d6
Author: Artem Glazychev
Date: 2024-04-02 16:48:55 +0700
Message:
  - Move registry expiration handling from updatepath to expire (#1606)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Apr 2, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
754d8e7 
…k@main

PR link: networkservicemesh/sdk#1606

Commit: f0105d6
Author: Artem Glazychev
Date: 2024-04-02 16:48:55 +0700
Message:
  - Move registry expiration handling from updatepath to expire (#1606)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Apr 2, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
49e05b9 
…k@main

PR link: networkservicemesh/sdk#1606

Commit: f0105d6
Author: Artem Glazychev
Date: 2024-04-02 16:48:55 +0700
Message:
  - Move registry expiration handling from updatepath to expire (#1606)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Apr 2, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
b51c7b4 
…k@main

PR link: networkservicemesh/sdk#1606

Commit: f0105d6
Author: Artem Glazychev
Date: 2024-04-02 16:48:55 +0700
Message:
  - Move registry expiration handling from updatepath to expire (#1606)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Apr 2, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
e9b78c9 
…k@main

PR link: networkservicemesh/sdk#1606

Commit: f0105d6
Author: Artem Glazychev
Date: 2024-04-02 16:48:55 +0700
Message:
  - Move registry expiration handling from updatepath to expire (#1606)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Apr 2, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
73711d9 
…k@main

PR link: networkservicemesh/sdk#1606

Commit: f0105d6
Author: Artem Glazychev
Date: 2024-04-02 16:48:55 +0700
Message:
  - Move registry expiration handling from updatepath to expire (#1606)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Apr 2, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
ed5e1e3 
…k@main

PR link: networkservicemesh/sdk#1606

Commit: f0105d6
Author: Artem Glazychev
Date: 2024-04-02 16:48:55 +0700
Message:
  - Move registry expiration handling from updatepath to expire (#1606)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Apr 2, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
fc5d9da 
…k@main

PR link: networkservicemesh/sdk#1606

Commit: f0105d6
Author: Artem Glazychev
Date: 2024-04-02 16:48:55 +0700
Message:
  - Move registry expiration handling from updatepath to expire (#1606)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Apr 2, 2024
Merged
Merged
Merged
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Apr 2, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
119984a 
…k@main

PR link: networkservicemesh/sdk#1606

Commit: f0105d6
Author: Artem Glazychev
Date: 2024-04-02 16:48:55 +0700
Message:
  - Move registry expiration handling from updatepath to expire (#1606)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Apr 2, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
cb5640e 
…k@main

PR link: networkservicemesh/sdk#1606

Commit: f0105d6
Author: Artem Glazychev
Date: 2024-04-02 16:48:55 +0700
Message:
  - Move registry expiration handling from updatepath to expire (#1606)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Apr 2, 2024
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Apr 2, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

Assignees

@glazychev-art glazychev-art

Labels
None yet
Projects
Release v1.13.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glazychev-art @denis-tingaikin