Make the kernel generateInterfaceName function public #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1607 +/- ##
=======================================
Coverage ? 67.42%
=======================================
Files ? 264
Lines ? 12493
Branches ? 0
=======================================
Hits ? 8424
Misses ? 3545
Partials ? 524 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
denis-tingaikin
approved these changes
Apr 4, 2024
pkg/tools/nanoid/utils.go
Outdated
|
|
||
| // GenerateLinuxInterfaceName - returns a random interface name with "nsm" prefix | ||
| // to achieve a 1% chance of name collision, you need to generate approximately 68 billon names | ||
| func GenerateLinuxInterfaceName(generator func(int) (string, error)) (string, error) { |
There was a problem hiding this comment.
Suggested change
| func GenerateLinuxInterfaceName(generator func(int) (string, error)) (string, error) { | |
| func GenerateLinuxInterfaceName() (string, error) { |
pkg/tools/nanoid/utils.go
Outdated
| // to achieve a 1% chance of name collision, you need to generate approximately 68 billon names | ||
| func GenerateLinuxInterfaceName(generator func(int) (string, error)) (string, error) { | ||
| ifIDLen := kernelmech.LinuxIfMaxLength - len(ifPrefix) | ||
| id, err := generator(ifIDLen) |
There was a problem hiding this comment.
Suggested change
| id, err := generator(ifIDLen) | |
| id, err := RandomString(ifIDLen, WithAlphabet(...)) |
| @@ -58,7 +58,7 @@ func (m *kernelMechanismServer) Request(ctx context.Context, request *networkser | |||
| if m.interfaceName != "" { | |||
| mechanism.SetInterfaceName(m.interfaceName) | |||
| } else { | |||
| ifname, err := generateInterfaceName(m.interfaceNameGenerator) | |||
| ifname, err := nanoid.GenerateLinuxInterfaceName(m.interfaceNameGenerator) | |||
There was a problem hiding this comment.
Suggested change
| ifname, err := nanoid.GenerateLinuxInterfaceName(m.interfaceNameGenerator) | |
| ifname, err := nanoid.GenerateLinuxInterfaceName() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue link
networkservicemesh/integration-k8s-gke#435
How Has This Been Tested?
Types of changes