Add a new wrapper for point2point IPAM that filters invalid addresses and routes
#1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
NikitaSkrynnik
force-pushed
the
ipam-issue
branch
from
b8326a6 to
4e47f53
Compare
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
NikitaSkrynnik
changed the title
ipam doesn't check if addresses are already allocated
NikitaSkrynnik
changed the title
ipam doesn't check if addresses are already allocatedpoint2point IPAM doesn't check if addresses are already allocated
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1647 +/- ##
=======================================
Coverage ? 67.94%
=======================================
Files ? 265
Lines ? 12677
Branches ? 0
=======================================
Hits ? 8614
Misses ? 3531
Partials ? 532 ☔ View full report in Codecov by Sentry. |
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
NikitaSkrynnik
force-pushed
the
ipam-issue
branch
from
eae7bc0 to
a097588
Compare
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
NikitaSkrynnik
changed the title
point2point IPAM doesn't check if addresses are already allocatedpoint2point IPAM doesn't check if addresses are already allocated
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
NikitaSkrynnik
changed the title
point2point IPAM doesn't check if addresses are already allocatedpoint2point IPAM that filters invalid addresses and routes
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
NikitaSkrynnik
force-pushed
the
ipam-issue
branch
from
4025b29 to
052572f
Compare
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
| if newIPAMServer == nil { | ||
| panic("newIPAMServer should not be nil") | ||
| } | ||
| ipPool := ippool.New(net.IPv6len) |
There was a problem hiding this comment.
TODO: consider using dualstack ippool
| "github.com/networkservicemesh/sdk/pkg/tools/ippool" | ||
| ) | ||
|
|
||
| type filterIPAMServer struct { |
There was a problem hiding this comment.
Consider better naming. For example primaryipam .
| } | ||
|
|
||
| func (s *filterIPAMServer) getInvalidAddrs(addrs []string) []string { | ||
| invalidAddrs := make([]string, 0) |
There was a problem hiding this comment.
Suggested change
| invalidAddrs := make([]string, 0) | |
| invalidAddrs := []string(nil) |
ljkiraly
reviewed
Oct 15, 2024
| for _, addr := range ipContext.SrcIpAddrs { | ||
| _, ipNet, err := net.ParseCIDR(addr) | ||
| if err != nil { | ||
| return |
There was a problem hiding this comment.
We don't expect any error here, but don't we want to free the rest?
|
The same functionality has been implemented in this PR: #1679 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If
point2pointIPAM receives a request with filledip_contextit doesn't check if some ofip_context's addresses are already allocated for other connections. The PR adds a new wrapper forpoint2pointIPAM that filters already allocated addresses.Issue link
networkservicemesh/deployments-k8s#11787
How Has This Been Tested?
Types of changes