Add DualStack IPPool that support both IPv4 and IPv6 addresses #1659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
NikitaSkrynnik
force-pushed
the
dualstack-ippool
branch
from
9c598fe to
3c049f0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1659 +/- ##
=======================================
Coverage ? 67.78%
=======================================
Files ? 265
Lines ? 12626
Branches ? 0
=======================================
Hits ? 8559
Misses ? 3537
Partials ? 530 ☔ View full report in Codecov by Sentry. |
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
NikitaSkrynnik
force-pushed
the
dualstack-ippool
branch
from
3c049f0 to
8eb6043
Compare
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
NikitaSkrynnik
force-pushed
the
dualstack-ippool
branch
from
60f895d to
188832f
Compare
There was a problem hiding this comment.
As I know @Ex4amp1e has found a few problems with these changes during testing networkservicemesh/deployments-k8s#11371
So @Ex4amp1e is planned to continue this PR.
|
Taken the main part from here and implemented in the scope of the #1679 PR. |
|
Done in #1679 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a dual stack ippool that support both IPv4 and IPv6 addresses. It fixes some errors in
strictipamchain elementIssue link
How Has This Been Tested?
Types of changes