-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add boundary check to SetupLogLevelChange #1675
Merged
denis-tingaikin
merged 1 commit into
networkservicemesh:main
from
Nordix:arp_loglevelchange
Oct 4, 2024
Merged
Add boundary check to SetupLogLevelChange #1675
denis-tingaikin
merged 1 commit into
networkservicemesh:main
from
Nordix:arp_loglevelchange
Oct 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arpad Kiss <arpad.a.kiss@est.tech>
arp-est
force-pushed
the
arp_loglevelchange
branch
from
October 4, 2024 11:58
b5a6faa
to
520067b
Compare
denis-tingaikin
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nsmbot
pushed a commit
to networkservicemesh/cmd-csi-driver
that referenced
this pull request
Oct 4, 2024
…k@main PR link: networkservicemesh/sdk#1675 Commit: 95c7ff7 Author: Arpad Kiss Date: 2024-10-05 01:07:12 +0200 Message: - Add boundary check to SetupLogLevelChange (#1675) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Oct 4, 2024
…k@main PR link: networkservicemesh/sdk#1675 Commit: 95c7ff7 Author: Arpad Kiss Date: 2024-10-05 01:07:12 +0200 Message: - Add boundary check to SetupLogLevelChange (#1675) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Oct 4, 2024
…k@main PR link: networkservicemesh/sdk#1675 Commit: 95c7ff7 Author: Arpad Kiss Date: 2024-10-05 01:07:12 +0200 Message: - Add boundary check to SetupLogLevelChange (#1675) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Oct 4, 2024
…k@main PR link: networkservicemesh/sdk#1675 Commit: 95c7ff7 Author: Arpad Kiss Date: 2024-10-05 01:07:12 +0200 Message: - Add boundary check to SetupLogLevelChange (#1675) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Oct 4, 2024
…k@main PR link: networkservicemesh/sdk#1675 Commit: 95c7ff7 Author: Arpad Kiss Date: 2024-10-05 01:07:12 +0200 Message: - Add boundary check to SetupLogLevelChange (#1675) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-dashboard-backend
that referenced
this pull request
Oct 4, 2024
…k@main PR link: networkservicemesh/sdk#1675 Commit: 95c7ff7 Author: Arpad Kiss Date: 2024-10-05 01:07:12 +0200 Message: - Add boundary check to SetupLogLevelChange (#1675) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Oct 4, 2024
…k@main PR link: networkservicemesh/sdk#1675 Commit: 95c7ff7 Author: Arpad Kiss Date: 2024-10-05 01:07:12 +0200 Message: - Add boundary check to SetupLogLevelChange (#1675) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Oct 4, 2024
…k@main PR link: networkservicemesh/sdk#1675 Commit: 95c7ff7 Author: Arpad Kiss Date: 2024-10-05 01:07:12 +0200 Message: - Add boundary check to SetupLogLevelChange (#1675) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Oct 4, 2024
…k@main PR link: networkservicemesh/sdk#1675 Commit: 95c7ff7 Author: Arpad Kiss Date: 2024-10-05 01:07:12 +0200 Message: - Add boundary check to SetupLogLevelChange (#1675) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Oct 4, 2024
…k@main PR link: networkservicemesh/sdk#1675 Commit: 95c7ff7 Author: Arpad Kiss Date: 2024-10-05 01:07:12 +0200 Message: - Add boundary check to SetupLogLevelChange (#1675) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Oct 4, 2024
…k@main PR link: networkservicemesh/sdk#1675 Commit: 95c7ff7 Author: Arpad Kiss Date: 2024-10-05 01:07:12 +0200 Message: - Add boundary check to SetupLogLevelChange (#1675) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Oct 4, 2024
…k@main PR link: networkservicemesh/sdk#1675 Commit: 95c7ff7 Author: Arpad Kiss Date: 2024-10-05 01:07:12 +0200 Message: - Add boundary check to SetupLogLevelChange (#1675) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Oct 4, 2024
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Oct 4, 2024
…k@main PR link: networkservicemesh/sdk#1675 Commit: 95c7ff7 Author: Arpad Kiss Date: 2024-10-05 01:07:12 +0200 Message: - Add boundary check to SetupLogLevelChange (#1675) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
to networkservicemesh/cmd-nse-vl3-vpp
that referenced
this pull request
Oct 4, 2024
…k-vpp@main (#365) PR link: networkservicemesh/sdk-vpp#855 Commit: e03e1c1 Author: Network Service Mesh Bot Date: 2024-10-04 18:13:14 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#855) PR link: networkservicemesh/sdk-kernel#683 Commit: f5852d2 Author: Network Service Mesh Bot Date: 2024-10-04 18:09:31 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#683) PR link: networkservicemesh/sdk#1675 Commit: 95c7ff7 Author: Arpad Kiss Date: 2024-10-05 01:07:12 +0200 Message: - Add boundary check to SetupLogLevelChange (#1675) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Oct 4, 2024
…d-nse-icmp-responder@main PR link: networkservicemesh/cmd-nse-icmp-responder#617 Commit: 57c59ff Author: Network Service Mesh Bot Date: 2024-10-04 18:16:17 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main (#617) PR link: networkservicemesh/sdk-sriov#612 Commit: dc8c91b Author: Network Service Mesh Bot Date: 2024-10-04 18:12:53 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#612) PR link: networkservicemesh/sdk-kernel#683 Commit: f5852d2 Author: Network Service Mesh Bot Date: 2024-10-04 18:09:31 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#683) PR link: networkservicemesh/sdk#1675 Commit: 95c7ff7 Author: Arpad Kiss Date: 2024-10-05 01:07:12 +0200 Message: - Add boundary check to SetupLogLevelChange (#1675) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Oct 4, 2024
…d-nse-vlan-vpp@main PR link: networkservicemesh/cmd-nse-vlan-vpp#513 Commit: 3731497 Author: Network Service Mesh Bot Date: 2024-10-04 18:16:14 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main (#513) PR link: networkservicemesh/sdk-sriov#612 Commit: dc8c91b Author: Network Service Mesh Bot Date: 2024-10-04 18:12:53 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#612) PR link: networkservicemesh/sdk-kernel#683 Commit: f5852d2 Author: Network Service Mesh Bot Date: 2024-10-04 18:09:31 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#683) PR link: networkservicemesh/sdk#1675 Commit: 95c7ff7 Author: Arpad Kiss Date: 2024-10-05 01:07:12 +0200 Message: - Add boundary check to SetupLogLevelChange (#1675) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
to networkservicemesh/cmd-lb-vl3-vpp
that referenced
this pull request
Oct 4, 2024
…k-vpp@main (#104) PR link: networkservicemesh/sdk-vpp#855 Commit: e03e1c1 Author: Network Service Mesh Bot Date: 2024-10-04 18:13:14 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#855) PR link: networkservicemesh/sdk-kernel#683 Commit: f5852d2 Author: Network Service Mesh Bot Date: 2024-10-04 18:09:31 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#683) PR link: networkservicemesh/sdk#1675 Commit: 95c7ff7 Author: Arpad Kiss Date: 2024-10-05 01:07:12 +0200 Message: - Add boundary check to SetupLogLevelChange (#1675) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
to networkservicemesh/cmd-nse-icmp-responder-vpp
that referenced
this pull request
Oct 4, 2024
…k-vpp@main (#702) PR link: networkservicemesh/sdk-vpp#855 Commit: e03e1c1 Author: Network Service Mesh Bot Date: 2024-10-04 18:13:14 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#855) PR link: networkservicemesh/sdk-kernel#683 Commit: f5852d2 Author: Network Service Mesh Bot Date: 2024-10-04 18:09:31 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#683) PR link: networkservicemesh/sdk#1675 Commit: 95c7ff7 Author: Arpad Kiss Date: 2024-10-05 01:07:12 +0200 Message: - Add boundary check to SetupLogLevelChange (#1675) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
to networkservicemesh/cmd-nse-simple-vl3-docker
that referenced
this pull request
Oct 4, 2024
…k-vpp@main (#268) PR link: networkservicemesh/sdk-vpp#855 Commit: e03e1c1 Author: Network Service Mesh Bot Date: 2024-10-04 18:13:14 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#855) PR link: networkservicemesh/sdk-kernel#683 Commit: f5852d2 Author: Network Service Mesh Bot Date: 2024-10-04 18:09:31 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#683) PR link: networkservicemesh/sdk#1675 Commit: 95c7ff7 Author: Arpad Kiss Date: 2024-10-05 01:07:12 +0200 Message: - Add boundary check to SetupLogLevelChange (#1675) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
to networkservicemesh/cmd-nse-firewall-vpp
that referenced
this pull request
Oct 4, 2024
…k-vpp@main (#538) PR link: networkservicemesh/sdk-vpp#855 Commit: e03e1c1 Author: Network Service Mesh Bot Date: 2024-10-04 18:13:14 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#855) PR link: networkservicemesh/sdk-kernel#683 Commit: f5852d2 Author: Network Service Mesh Bot Date: 2024-10-04 18:09:31 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#683) PR link: networkservicemesh/sdk#1675 Commit: 95c7ff7 Author: Arpad Kiss Date: 2024-10-05 01:07:12 +0200 Message: - Add boundary check to SetupLogLevelChange (#1675) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Oct 4, 2024
…d-forwarder-sriov@main PR link: networkservicemesh/cmd-forwarder-sriov#775 Commit: 099c344 Author: Network Service Mesh Bot Date: 2024-10-04 18:16:29 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main (#775) PR link: networkservicemesh/sdk-sriov#612 Commit: dc8c91b Author: Network Service Mesh Bot Date: 2024-10-04 18:12:53 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#612) PR link: networkservicemesh/sdk-kernel#683 Commit: f5852d2 Author: Network Service Mesh Bot Date: 2024-10-04 18:09:31 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#683) PR link: networkservicemesh/sdk#1675 Commit: 95c7ff7 Author: Arpad Kiss Date: 2024-10-05 01:07:12 +0200 Message: - Add boundary check to SetupLogLevelChange (#1675) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Oct 4, 2024
…d-nse-vl3-vpp@main PR link: networkservicemesh/cmd-nse-vl3-vpp#365 Commit: 51c3da3 Author: Network Service Mesh Bot Date: 2024-10-04 18:16:33 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main (#365) PR link: networkservicemesh/sdk-vpp#855 Commit: e03e1c1 Author: Network Service Mesh Bot Date: 2024-10-04 18:13:14 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#855) PR link: networkservicemesh/sdk-kernel#683 Commit: f5852d2 Author: Network Service Mesh Bot Date: 2024-10-04 18:09:31 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#683) PR link: networkservicemesh/sdk#1675 Commit: 95c7ff7 Author: Arpad Kiss Date: 2024-10-05 01:07:12 +0200 Message: - Add boundary check to SetupLogLevelChange (#1675) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Oct 4, 2024
…d-nse-icmp-responder-vpp@main PR link: networkservicemesh/cmd-nse-icmp-responder-vpp#702 Commit: 10232c5 Author: Network Service Mesh Bot Date: 2024-10-04 18:16:37 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main (#702) PR link: networkservicemesh/sdk-vpp#855 Commit: e03e1c1 Author: Network Service Mesh Bot Date: 2024-10-04 18:13:14 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#855) PR link: networkservicemesh/sdk-kernel#683 Commit: f5852d2 Author: Network Service Mesh Bot Date: 2024-10-04 18:09:31 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#683) PR link: networkservicemesh/sdk#1675 Commit: 95c7ff7 Author: Arpad Kiss Date: 2024-10-05 01:07:12 +0200 Message: - Add boundary check to SetupLogLevelChange (#1675) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Oct 4, 2024
…d-lb-vl3-vpp@main PR link: networkservicemesh/cmd-lb-vl3-vpp#104 Commit: 4fcb5c5 Author: Network Service Mesh Bot Date: 2024-10-04 18:16:36 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main (#104) PR link: networkservicemesh/sdk-vpp#855 Commit: e03e1c1 Author: Network Service Mesh Bot Date: 2024-10-04 18:13:14 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#855) PR link: networkservicemesh/sdk-kernel#683 Commit: f5852d2 Author: Network Service Mesh Bot Date: 2024-10-04 18:09:31 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#683) PR link: networkservicemesh/sdk#1675 Commit: 95c7ff7 Author: Arpad Kiss Date: 2024-10-05 01:07:12 +0200 Message: - Add boundary check to SetupLogLevelChange (#1675) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Oct 4, 2024
…d-nse-simple-vl3-docker@main PR link: networkservicemesh/cmd-nse-simple-vl3-docker#268 Commit: efa1fcc Author: Network Service Mesh Bot Date: 2024-10-04 18:16:39 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main (#268) PR link: networkservicemesh/sdk-vpp#855 Commit: e03e1c1 Author: Network Service Mesh Bot Date: 2024-10-04 18:13:14 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#855) PR link: networkservicemesh/sdk-kernel#683 Commit: f5852d2 Author: Network Service Mesh Bot Date: 2024-10-04 18:09:31 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#683) PR link: networkservicemesh/sdk#1675 Commit: 95c7ff7 Author: Arpad Kiss Date: 2024-10-05 01:07:12 +0200 Message: - Add boundary check to SetupLogLevelChange (#1675) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Oct 4, 2024
…d-nse-firewall-vpp@main PR link: networkservicemesh/cmd-nse-firewall-vpp#538 Commit: 561a84d Author: Network Service Mesh Bot Date: 2024-10-04 18:16:42 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main (#538) PR link: networkservicemesh/sdk-vpp#855 Commit: e03e1c1 Author: Network Service Mesh Bot Date: 2024-10-04 18:13:14 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#855) PR link: networkservicemesh/sdk-kernel#683 Commit: f5852d2 Author: Network Service Mesh Bot Date: 2024-10-04 18:09:31 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#683) PR link: networkservicemesh/sdk#1675 Commit: 95c7ff7 Author: Arpad Kiss Date: 2024-10-05 01:07:12 +0200 Message: - Add boundary check to SetupLogLevelChange (#1675) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Oct 4, 2024
Merged
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-ovs
that referenced
this pull request
Oct 4, 2024
…k-ovs@main PR link: networkservicemesh/sdk-ovs#342 Commit: 4a1609d Author: Network Service Mesh Bot Date: 2024-10-04 18:16:26 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main (#342) PR link: networkservicemesh/sdk-sriov#612 Commit: dc8c91b Author: Network Service Mesh Bot Date: 2024-10-04 18:12:53 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#612) PR link: networkservicemesh/sdk-kernel#683 Commit: f5852d2 Author: Network Service Mesh Bot Date: 2024-10-04 18:09:31 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#683) PR link: networkservicemesh/sdk#1675 Commit: 95c7ff7 Author: Arpad Kiss Date: 2024-10-05 01:07:12 +0200 Message: - Add boundary check to SetupLogLevelChange (#1675) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Oct 4, 2024
…d-nsc@main (#12353) PR link: networkservicemesh/cmd-nsc#652 Commit: 819ccb7 Author: Network Service Mesh Bot Date: 2024-10-04 18:15:58 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main (#652) PR link: networkservicemesh/sdk-sriov#612 Commit: dc8c91b Author: Network Service Mesh Bot Date: 2024-10-04 18:12:53 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#612) PR link: networkservicemesh/sdk-kernel#683 Commit: f5852d2 Author: Network Service Mesh Bot Date: 2024-10-04 18:09:31 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#683) PR link: networkservicemesh/sdk#1675 Commit: 95c7ff7 Author: Arpad Kiss Date: 2024-10-05 01:07:12 +0200 Message: - Add boundary check to SetupLogLevelChange (#1675) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Oct 4, 2024
…d-nsc-init@main (#12354) PR link: networkservicemesh/cmd-nsc-init#782 Commit: 306aafe Author: Network Service Mesh Bot Date: 2024-10-04 18:16:03 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main (#782) PR link: networkservicemesh/sdk-sriov#612 Commit: dc8c91b Author: Network Service Mesh Bot Date: 2024-10-04 18:12:53 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#612) PR link: networkservicemesh/sdk-kernel#683 Commit: f5852d2 Author: Network Service Mesh Bot Date: 2024-10-04 18:09:31 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#683) PR link: networkservicemesh/sdk#1675 Commit: 95c7ff7 Author: Arpad Kiss Date: 2024-10-05 01:07:12 +0200 Message: - Add boundary check to SetupLogLevelChange (#1675) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Oct 4, 2024
…d-nse-icmp-responder@main (#12344) PR link: networkservicemesh/cmd-nse-icmp-responder#617 Commit: 57c59ff Author: Network Service Mesh Bot Date: 2024-10-04 18:16:17 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main (#617) PR link: networkservicemesh/sdk-sriov#612 Commit: dc8c91b Author: Network Service Mesh Bot Date: 2024-10-04 18:12:53 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#612) PR link: networkservicemesh/sdk-kernel#683 Commit: f5852d2 Author: Network Service Mesh Bot Date: 2024-10-04 18:09:31 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#683) PR link: networkservicemesh/sdk#1675 Commit: 95c7ff7 Author: Arpad Kiss Date: 2024-10-05 01:07:12 +0200 Message: - Add boundary check to SetupLogLevelChange (#1675) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
to networkservicemesh/cmd-nse-vlan-vpp
that referenced
this pull request
Oct 4, 2024
* Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main PR link: networkservicemesh/sdk-vpp#855 Commit: e03e1c1 Author: Network Service Mesh Bot Date: 2024-10-04 18:13:14 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#855) PR link: networkservicemesh/sdk-kernel#683 Commit: f5852d2 Author: Network Service Mesh Bot Date: 2024-10-04 18:09:31 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#683) PR link: networkservicemesh/sdk#1675 Commit: 95c7ff7 Author: Arpad Kiss Date: 2024-10-05 01:07:12 +0200 Message: - Add boundary check to SetupLogLevelChange (#1675) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> * Automatically resolving conflicts in go.mod and updating dependency versions to the latest Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Oct 4, 2024
…d-nse-vlan-vpp@main PR link: networkservicemesh/cmd-nse-vlan-vpp#514 Commit: 4823bf1 Author: Network Service Mesh Bot Date: 2024-10-04 18:19:49 -0500 Message: - Update from update/networkservicemesh/sdk-vpp (#514) * Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main PR link: networkservicemesh/sdk-vpp#855 Commit: e03e1c1 Author: Network Service Mesh Bot Date: 2024-10-04 18:13:14 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#855) PR link: networkservicemesh/sdk-kernel#683 Commit: f5852d2 Author: Network Service Mesh Bot Date: 2024-10-04 18:09:31 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#683) PR link: networkservicemesh/sdk#1675 Commit: 95c7ff7 Author: Arpad Kiss Date: 2024-10-05 01:07:12 +0200 Message: - Add boundary check to SetupLogLevelChange (#1675) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> * Automatically resolving conflicts in go.mod and updating dependency versions to the latest Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
to networkservicemesh/cmd-forwarder-ovs
that referenced
this pull request
Oct 4, 2024
…k-ovs@main (#417) PR link: networkservicemesh/sdk-ovs#342 Commit: 4a1609d Author: Network Service Mesh Bot Date: 2024-10-04 18:16:26 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main (#342) PR link: networkservicemesh/sdk-sriov#612 Commit: dc8c91b Author: Network Service Mesh Bot Date: 2024-10-04 18:12:53 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#612) PR link: networkservicemesh/sdk-kernel#683 Commit: f5852d2 Author: Network Service Mesh Bot Date: 2024-10-04 18:09:31 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#683) PR link: networkservicemesh/sdk#1675 Commit: 95c7ff7 Author: Arpad Kiss Date: 2024-10-05 01:07:12 +0200 Message: - Add boundary check to SetupLogLevelChange (#1675) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Oct 4, 2024
…d-forwarder-ovs@main PR link: networkservicemesh/cmd-forwarder-ovs#417 Commit: 41521e0 Author: Network Service Mesh Bot Date: 2024-10-04 18:20:11 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-ovs@main (#417) PR link: networkservicemesh/sdk-ovs#342 Commit: 4a1609d Author: Network Service Mesh Bot Date: 2024-10-04 18:16:26 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main (#342) PR link: networkservicemesh/sdk-sriov#612 Commit: dc8c91b Author: Network Service Mesh Bot Date: 2024-10-04 18:12:53 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#612) PR link: networkservicemesh/sdk-kernel#683 Commit: f5852d2 Author: Network Service Mesh Bot Date: 2024-10-04 18:09:31 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#683) PR link: networkservicemesh/sdk#1675 Commit: 95c7ff7 Author: Arpad Kiss Date: 2024-10-05 01:07:12 +0200 Message: - Add boundary check to SetupLogLevelChange (#1675) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Oct 4, 2024
…d-nse-vlan-vpp@main (#12355) PR link: networkservicemesh/cmd-nse-vlan-vpp#514 Commit: 4823bf1 Author: Network Service Mesh Bot Date: 2024-10-04 18:19:49 -0500 Message: - Update from update/networkservicemesh/sdk-vpp (#514) * Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main PR link: networkservicemesh/sdk-vpp#855 Commit: e03e1c1 Author: Network Service Mesh Bot Date: 2024-10-04 18:13:14 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#855) PR link: networkservicemesh/sdk-kernel#683 Commit: f5852d2 Author: Network Service Mesh Bot Date: 2024-10-04 18:09:31 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#683) PR link: networkservicemesh/sdk#1675 Commit: 95c7ff7 Author: Arpad Kiss Date: 2024-10-05 01:07:12 +0200 Message: - Add boundary check to SetupLogLevelChange (#1675) * Automatically resolving conflicts in go.mod and updating dependency versions to the latest --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
denis-tingaikin
pushed a commit
that referenced
this pull request
Oct 17, 2024
Signed-off-by: Arpad Kiss <arpad.a.kiss@est.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a few additional checks to the setup according to the comments below
Though I'm not super confident whether these changes make it any better, but I'm out of ideas.
It might be worth reducing the array size to fixed 2, as there's not much else than SIGUSR1, and SIGUSR2 for usage.
Also checking whether the values are the same in the map came out a bit too long, not sure if worth it.
Also there's only a single log line indicating that this thing is disabled, it could be a bit confusing, if someone gets used to the feature and doesn't see any log messages when he sends a signal.
So not sure what do you think?
Issue link
networkservicemesh/cmd-forwarder-vpp#1171 (comment)
networkservicemesh/deployments-k8s#12296
How Has This Been Tested?
Types of changes