Revert changes in begin and dial
#1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orkservicemesh#1656)" This reverts commit 6fad31a. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
…networkservicemesh#1670)" This reverts commit b66e1bf. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
NikitaSkrynnik
force-pushed
the
revert-begin-dial
branch
from
c9c71d1 to
aa5a9e4
Compare
denis-tingaikin
approved these changes
Oct 15, 2024
nsmbot
pushed a commit
to networkservicemesh/cmd-csi-driver
that referenced
this pull request
Oct 15, 2024
…k@main PR link: networkservicemesh/sdk#1682 Commit: 083d4e2 Author: Nikita Skrynnik Date: 2024-10-15 16:56:31 +0700 Message: - Revert changes in `begin` and `dial` (#1682) * Revert "Use a context with exteded timeout on Requests in begin (#1656)" This reverts commit 6fad31a9f0aa1e2b927d93da26423cd20aa354eb. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * Revert "Add a timeout for Closes in begin.Server (#1650)" This reverts commit 301631365421a9d916a5ab7224fa9fbd847320b2. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * Revert "Add more mutexes in dial chain element to fix race conditions (#1670)" This reverts commit b66e1bf47abb91cdf494b5eef05fda13c6d36b71. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Oct 15, 2024
…k@main PR link: networkservicemesh/sdk#1682 Commit: 083d4e2 Author: Nikita Skrynnik Date: 2024-10-15 16:56:31 +0700 Message: - Revert changes in `begin` and `dial` (#1682) * Revert "Use a context with exteded timeout on Requests in begin (#1656)" This reverts commit 6fad31a9f0aa1e2b927d93da26423cd20aa354eb. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * Revert "Add a timeout for Closes in begin.Server (#1650)" This reverts commit 301631365421a9d916a5ab7224fa9fbd847320b2. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * Revert "Add more mutexes in dial chain element to fix race conditions (#1670)" This reverts commit b66e1bf47abb91cdf494b5eef05fda13c6d36b71. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Oct 15, 2024
…k@main PR link: networkservicemesh/sdk#1682 Commit: 083d4e2 Author: Nikita Skrynnik Date: 2024-10-15 16:56:31 +0700 Message: - Revert changes in `begin` and `dial` (#1682) * Revert "Use a context with exteded timeout on Requests in begin (#1656)" This reverts commit 6fad31a9f0aa1e2b927d93da26423cd20aa354eb. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * Revert "Add a timeout for Closes in begin.Server (#1650)" This reverts commit 301631365421a9d916a5ab7224fa9fbd847320b2. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * Revert "Add more mutexes in dial chain element to fix race conditions (#1670)" This reverts commit b66e1bf47abb91cdf494b5eef05fda13c6d36b71. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Oct 15, 2024
…k@main PR link: networkservicemesh/sdk#1682 Commit: 083d4e2 Author: Nikita Skrynnik Date: 2024-10-15 16:56:31 +0700 Message: - Revert changes in `begin` and `dial` (#1682) * Revert "Use a context with exteded timeout on Requests in begin (#1656)" This reverts commit 6fad31a9f0aa1e2b927d93da26423cd20aa354eb. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * Revert "Add a timeout for Closes in begin.Server (#1650)" This reverts commit 301631365421a9d916a5ab7224fa9fbd847320b2. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * Revert "Add more mutexes in dial chain element to fix race conditions (#1670)" This reverts commit b66e1bf47abb91cdf494b5eef05fda13c6d36b71. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Oct 15, 2024
…k@main PR link: networkservicemesh/sdk#1682 Commit: 083d4e2 Author: Nikita Skrynnik Date: 2024-10-15 16:56:31 +0700 Message: - Revert changes in `begin` and `dial` (#1682) * Revert "Use a context with exteded timeout on Requests in begin (#1656)" This reverts commit 6fad31a9f0aa1e2b927d93da26423cd20aa354eb. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * Revert "Add a timeout for Closes in begin.Server (#1650)" This reverts commit 301631365421a9d916a5ab7224fa9fbd847320b2. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * Revert "Add more mutexes in dial chain element to fix race conditions (#1670)" This reverts commit b66e1bf47abb91cdf494b5eef05fda13c6d36b71. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Oct 15, 2024
…k@main PR link: networkservicemesh/sdk#1682 Commit: 083d4e2 Author: Nikita Skrynnik Date: 2024-10-15 16:56:31 +0700 Message: - Revert changes in `begin` and `dial` (#1682) * Revert "Use a context with exteded timeout on Requests in begin (#1656)" This reverts commit 6fad31a9f0aa1e2b927d93da26423cd20aa354eb. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * Revert "Add a timeout for Closes in begin.Server (#1650)" This reverts commit 301631365421a9d916a5ab7224fa9fbd847320b2. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * Revert "Add more mutexes in dial chain element to fix race conditions (#1670)" This reverts commit b66e1bf47abb91cdf494b5eef05fda13c6d36b71. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Oct 15, 2024
…k@main PR link: networkservicemesh/sdk#1682 Commit: 083d4e2 Author: Nikita Skrynnik Date: 2024-10-15 16:56:31 +0700 Message: - Revert changes in `begin` and `dial` (#1682) * Revert "Use a context with exteded timeout on Requests in begin (#1656)" This reverts commit 6fad31a9f0aa1e2b927d93da26423cd20aa354eb. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * Revert "Add a timeout for Closes in begin.Server (#1650)" This reverts commit 301631365421a9d916a5ab7224fa9fbd847320b2. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * Revert "Add more mutexes in dial chain element to fix race conditions (#1670)" This reverts commit b66e1bf47abb91cdf494b5eef05fda13c6d36b71. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Oct 15, 2024
…k@main PR link: networkservicemesh/sdk#1682 Commit: 083d4e2 Author: Nikita Skrynnik Date: 2024-10-15 16:56:31 +0700 Message: - Revert changes in `begin` and `dial` (#1682) * Revert "Use a context with exteded timeout on Requests in begin (#1656)" This reverts commit 6fad31a9f0aa1e2b927d93da26423cd20aa354eb. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * Revert "Add a timeout for Closes in begin.Server (#1650)" This reverts commit 301631365421a9d916a5ab7224fa9fbd847320b2. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * Revert "Add more mutexes in dial chain element to fix race conditions (#1670)" This reverts commit b66e1bf47abb91cdf494b5eef05fda13c6d36b71. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Oct 15, 2024
…k@main PR link: networkservicemesh/sdk#1682 Commit: 083d4e2 Author: Nikita Skrynnik Date: 2024-10-15 16:56:31 +0700 Message: - Revert changes in `begin` and `dial` (#1682) * Revert "Use a context with exteded timeout on Requests in begin (#1656)" This reverts commit 6fad31a9f0aa1e2b927d93da26423cd20aa354eb. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * Revert "Add a timeout for Closes in begin.Server (#1650)" This reverts commit 301631365421a9d916a5ab7224fa9fbd847320b2. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * Revert "Add more mutexes in dial chain element to fix race conditions (#1670)" This reverts commit b66e1bf47abb91cdf494b5eef05fda13c6d36b71. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Oct 15, 2024
…k@main PR link: networkservicemesh/sdk#1682 Commit: 083d4e2 Author: Nikita Skrynnik Date: 2024-10-15 16:56:31 +0700 Message: - Revert changes in `begin` and `dial` (#1682) * Revert "Use a context with exteded timeout on Requests in begin (#1656)" This reverts commit 6fad31a9f0aa1e2b927d93da26423cd20aa354eb. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * Revert "Add a timeout for Closes in begin.Server (#1650)" This reverts commit 301631365421a9d916a5ab7224fa9fbd847320b2. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * Revert "Add more mutexes in dial chain element to fix race conditions (#1670)" This reverts commit b66e1bf47abb91cdf494b5eef05fda13c6d36b71. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Oct 15, 2024
…k@main PR link: networkservicemesh/sdk#1682 Commit: 083d4e2 Author: Nikita Skrynnik Date: 2024-10-15 16:56:31 +0700 Message: - Revert changes in `begin` and `dial` (#1682) * Revert "Use a context with exteded timeout on Requests in begin (#1656)" This reverts commit 6fad31a9f0aa1e2b927d93da26423cd20aa354eb. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * Revert "Add a timeout for Closes in begin.Server (#1650)" This reverts commit 301631365421a9d916a5ab7224fa9fbd847320b2. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * Revert "Add more mutexes in dial chain element to fix race conditions (#1670)" This reverts commit b66e1bf47abb91cdf494b5eef05fda13c6d36b71. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Oct 15, 2024
…k@main PR link: networkservicemesh/sdk#1682 Commit: 083d4e2 Author: Nikita Skrynnik Date: 2024-10-15 16:56:31 +0700 Message: - Revert changes in `begin` and `dial` (#1682) * Revert "Use a context with exteded timeout on Requests in begin (#1656)" This reverts commit 6fad31a9f0aa1e2b927d93da26423cd20aa354eb. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * Revert "Add a timeout for Closes in begin.Server (#1650)" This reverts commit 301631365421a9d916a5ab7224fa9fbd847320b2. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * Revert "Add more mutexes in dial chain element to fix race conditions (#1670)" This reverts commit b66e1bf47abb91cdf494b5eef05fda13c6d36b71. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-dashboard-backend
that referenced
this pull request
Oct 15, 2024
…k@main PR link: networkservicemesh/sdk#1682 Commit: 083d4e2 Author: Nikita Skrynnik Date: 2024-10-15 16:56:31 +0700 Message: - Revert changes in `begin` and `dial` (#1682) * Revert "Use a context with exteded timeout on Requests in begin (#1656)" This reverts commit 6fad31a9f0aa1e2b927d93da26423cd20aa354eb. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * Revert "Add a timeout for Closes in begin.Server (#1650)" This reverts commit 301631365421a9d916a5ab7224fa9fbd847320b2. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * Revert "Add more mutexes in dial chain element to fix race conditions (#1670)" This reverts commit b66e1bf47abb91cdf494b5eef05fda13c6d36b71. Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revert PRs:
because
netlinkis fixed now and doesn't cause inteface leaks: networkservicemesh/sdk-kernel#686Issue link
How Has This Been Tested?
Types of changes