-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove addressof from the client chain #581
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Albert Safin <albert.safin@xored.com>
denis-tingaikin
approved these changes
Nov 10, 2020
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder
that referenced
this pull request
Nov 10, 2020
…k@master networkservicemesh/sdk#581 networkservicemesh/sdk PR link: networkservicemesh/sdk#581 networkservicemesh/sdk commit message: commit 4a6442d84a9b9fb4b702c5031c22776e0c919637 Author: xzfc <xzfc@users.noreply.github.com> Date: Tue Nov 10 14:31:51 2020 +0000 Remove addressof from the client chain (#581) Signed-off-by: Albert Safin <albert.safin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Nov 10, 2020
…k@master networkservicemesh/sdk#581 networkservicemesh/sdk PR link: networkservicemesh/sdk#581 networkservicemesh/sdk commit message: commit 4a6442d84a9b9fb4b702c5031c22776e0c919637 Author: xzfc <xzfc@users.noreply.github.com> Date: Tue Nov 10 14:31:51 2020 +0000 Remove addressof from the client chain (#581) Signed-off-by: Albert Safin <albert.safin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Nov 10, 2020
…k@master networkservicemesh/sdk#581 networkservicemesh/sdk PR link: networkservicemesh/sdk#581 networkservicemesh/sdk commit message: commit 4a6442d84a9b9fb4b702c5031c22776e0c919637 Author: xzfc <xzfc@users.noreply.github.com> Date: Tue Nov 10 14:31:51 2020 +0000 Remove addressof from the client chain (#581) Signed-off-by: Albert Safin <albert.safin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Nov 10, 2020
…k@master networkservicemesh/sdk#581 networkservicemesh/sdk PR link: networkservicemesh/sdk#581 networkservicemesh/sdk commit message: commit 4a6442d84a9b9fb4b702c5031c22776e0c919637 Author: xzfc <xzfc@users.noreply.github.com> Date: Tue Nov 10 14:31:51 2020 +0000 Remove addressof from the client chain (#581) Signed-off-by: Albert Safin <albert.safin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Nov 10, 2020
…k@master networkservicemesh/sdk#581 networkservicemesh/sdk PR link: networkservicemesh/sdk#581 networkservicemesh/sdk commit message: commit 4a6442d84a9b9fb4b702c5031c22776e0c919637 Author: xzfc <xzfc@users.noreply.github.com> Date: Tue Nov 10 14:31:51 2020 +0000 Remove addressof from the client chain (#581) Signed-off-by: Albert Safin <albert.safin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Nov 10, 2020
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Nov 10, 2020
…k@master networkservicemesh/sdk#581 networkservicemesh/sdk PR link: networkservicemesh/sdk#581 networkservicemesh/sdk commit message: commit 4a6442d84a9b9fb4b702c5031c22776e0c919637 Author: xzfc <xzfc@users.noreply.github.com> Date: Tue Nov 10 14:31:51 2020 +0000 Remove addressof from the client chain (#581) Signed-off-by: Albert Safin <albert.safin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-vppagent
that referenced
this pull request
Nov 10, 2020
…k@master networkservicemesh/sdk#581 networkservicemesh/sdk PR link: networkservicemesh/sdk#581 networkservicemesh/sdk commit message: commit 4a6442d84a9b9fb4b702c5031c22776e0c919637 Author: xzfc <xzfc@users.noreply.github.com> Date: Tue Nov 10 14:31:51 2020 +0000 Remove addressof from the client chain (#581) Signed-off-by: Albert Safin <albert.safin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
illbegood
pushed a commit
to illbegood/sdk
that referenced
this pull request
Dec 20, 2020
Signed-off-by: Albert Safin <albert.safin@xored.com> Signed-off-by: Sergey Ershov <sergey.ershov@xored.com>
illbegood
pushed a commit
to illbegood/sdk
that referenced
this pull request
Dec 20, 2020
Signed-off-by: Albert Safin <albert.safin@xored.com> Signed-off-by: Sergey Ershov <sergey.ershov@xored.com>
illbegood
pushed a commit
to illbegood/sdk
that referenced
this pull request
Dec 23, 2020
Signed-off-by: Albert Safin <albert.safin@xored.com> Signed-off-by: Sergey Ershov <sergey.ershov@xored.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with the old code (simplified for the clarity):
This code is an equivalent to the following:
The new code:
Related: #534 (comment)
This is not the only instance where a similar issue with
addressof
occurs, I'll address the others in a separate issue.