Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove addressof from the client chain #581

Merged
merged 1 commit into from
Nov 10, 2020
Merged

Remove addressof from the client chain #581

merged 1 commit into from
Nov 10, 2020

Conversation

xzfc
Copy link
Contributor

@xzfc xzfc commented Nov 10, 2020

The issue with the old code (simplified for the clarity):

var rv networkservice.NetworkServiceClient
onHeal = addressof.NetworkServiceClient(rv)
rv = something()

// Now, *onHeal == nil, which isn't expected

This code is an equivalent to the following:

var rv networkservice.NetworkServiceClient
client := rv
onHeal = &client
rv = something()

// Now, *onHeal == nil, which isn't expected

The new code:

var rv networkservice.NetworkServiceClient
onHeal = &rv
rv = something()

// *onHeal == rv, as expected

Related: #534 (comment)
This is not the only instance where a similar issue with addressof occurs, I'll address the others in a separate issue.

Signed-off-by: Albert Safin <albert.safin@xored.com>
@denis-tingaikin denis-tingaikin merged commit 4a6442d into networkservicemesh:master Nov 10, 2020
nsmbot pushed a commit to networkservicemesh/cmd-nse-icmp-responder that referenced this pull request Nov 10, 2020
…k@master networkservicemesh/sdk#581

networkservicemesh/sdk PR link: networkservicemesh/sdk#581

networkservicemesh/sdk commit message:
commit 4a6442d84a9b9fb4b702c5031c22776e0c919637
Author: xzfc <xzfc@users.noreply.github.com>
Date:   Tue Nov 10 14:31:51 2020 +0000

    Remove addressof from the client chain (#581)

    Signed-off-by: Albert Safin <albert.safin@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Nov 10, 2020
…k@master networkservicemesh/sdk#581

networkservicemesh/sdk PR link: networkservicemesh/sdk#581

networkservicemesh/sdk commit message:
commit 4a6442d84a9b9fb4b702c5031c22776e0c919637
Author: xzfc <xzfc@users.noreply.github.com>
Date:   Tue Nov 10 14:31:51 2020 +0000

    Remove addressof from the client chain (#581)

    Signed-off-by: Albert Safin <albert.safin@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Nov 10, 2020
…k@master networkservicemesh/sdk#581

networkservicemesh/sdk PR link: networkservicemesh/sdk#581

networkservicemesh/sdk commit message:
commit 4a6442d84a9b9fb4b702c5031c22776e0c919637
Author: xzfc <xzfc@users.noreply.github.com>
Date:   Tue Nov 10 14:31:51 2020 +0000

    Remove addressof from the client chain (#581)

    Signed-off-by: Albert Safin <albert.safin@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Nov 10, 2020
…k@master networkservicemesh/sdk#581

networkservicemesh/sdk PR link: networkservicemesh/sdk#581

networkservicemesh/sdk commit message:
commit 4a6442d84a9b9fb4b702c5031c22776e0c919637
Author: xzfc <xzfc@users.noreply.github.com>
Date:   Tue Nov 10 14:31:51 2020 +0000

    Remove addressof from the client chain (#581)

    Signed-off-by: Albert Safin <albert.safin@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Nov 10, 2020
…k@master networkservicemesh/sdk#581

networkservicemesh/sdk PR link: networkservicemesh/sdk#581

networkservicemesh/sdk commit message:
commit 4a6442d84a9b9fb4b702c5031c22776e0c919637
Author: xzfc <xzfc@users.noreply.github.com>
Date:   Tue Nov 10 14:31:51 2020 +0000

    Remove addressof from the client chain (#581)

    Signed-off-by: Albert Safin <albert.safin@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Nov 10, 2020
…k@master networkservicemesh/sdk#581

networkservicemesh/sdk PR link: networkservicemesh/sdk#581

networkservicemesh/sdk commit message:
commit 4a6442d84a9b9fb4b702c5031c22776e0c919637
Author: xzfc <xzfc@users.noreply.github.com>
Date:   Tue Nov 10 14:31:51 2020 +0000

    Remove addressof from the client chain (#581)

    Signed-off-by: Albert Safin <albert.safin@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-vppagent that referenced this pull request Nov 10, 2020
…k@master networkservicemesh/sdk#581

networkservicemesh/sdk PR link: networkservicemesh/sdk#581

networkservicemesh/sdk commit message:
commit 4a6442d84a9b9fb4b702c5031c22776e0c919637
Author: xzfc <xzfc@users.noreply.github.com>
Date:   Tue Nov 10 14:31:51 2020 +0000

    Remove addressof from the client chain (#581)

    Signed-off-by: Albert Safin <albert.safin@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@xzfc xzfc mentioned this pull request Nov 10, 2020
illbegood pushed a commit to illbegood/sdk that referenced this pull request Dec 20, 2020
Signed-off-by: Albert Safin <albert.safin@xored.com>
Signed-off-by: Sergey Ershov <sergey.ershov@xored.com>
illbegood pushed a commit to illbegood/sdk that referenced this pull request Dec 20, 2020
Signed-off-by: Albert Safin <albert.safin@xored.com>
Signed-off-by: Sergey Ershov <sergey.ershov@xored.com>
illbegood pushed a commit to illbegood/sdk that referenced this pull request Dec 23, 2020
Signed-off-by: Albert Safin <albert.safin@xored.com>
Signed-off-by: Sergey Ershov <sergey.ershov@xored.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants