fix: common/roundrobin: should handle a case if selected endpoint returns error #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com>
denis-tingaikin
requested review from
haiodo and
edwarnicke
and removed request for
haiodo
Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com>
denis-tingaikin
force-pushed
the
fix_issue_597
branch
from
ff6b2a3
to
4607552
Compare
denis-tingaikin
changed the title
haiodo
reviewed
Nov 24, 2020
haiodo
approved these changes
Nov 24, 2020
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Nov 24, 2020
…k@master networkservicemesh/sdk#598 networkservicemesh/sdk PR link: networkservicemesh/sdk#598 networkservicemesh/sdk commit message: commit dae025c5ac5b6d6b8b88957671fb80cffa2e88d8 Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Tue Nov 24 15:46:33 2020 +0700 fix: common/roundrobin: should handle a case if selected endpoint returns error (#598) * fix issue 593 Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> * fix typo Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> * stabilize failing tests Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Nov 24, 2020
…k@master networkservicemesh/sdk#598 networkservicemesh/sdk PR link: networkservicemesh/sdk#598 networkservicemesh/sdk commit message: commit dae025c5ac5b6d6b8b88957671fb80cffa2e88d8 Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Tue Nov 24 15:46:33 2020 +0700 fix: common/roundrobin: should handle a case if selected endpoint returns error (#598) * fix issue 593 Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> * fix typo Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> * stabilize failing tests Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Nov 24, 2020
…k@master networkservicemesh/sdk#598 networkservicemesh/sdk PR link: networkservicemesh/sdk#598 networkservicemesh/sdk commit message: commit dae025c5ac5b6d6b8b88957671fb80cffa2e88d8 Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Tue Nov 24 15:46:33 2020 +0700 fix: common/roundrobin: should handle a case if selected endpoint returns error (#598) * fix issue 593 Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> * fix typo Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> * stabilize failing tests Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Nov 24, 2020
…k@master networkservicemesh/sdk#598 networkservicemesh/sdk PR link: networkservicemesh/sdk#598 networkservicemesh/sdk commit message: commit dae025c5ac5b6d6b8b88957671fb80cffa2e88d8 Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Tue Nov 24 15:46:33 2020 +0700 fix: common/roundrobin: should handle a case if selected endpoint returns error (#598) * fix issue 593 Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> * fix typo Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> * stabilize failing tests Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder
that referenced
this pull request
Nov 24, 2020
…k@master networkservicemesh/sdk#598 networkservicemesh/sdk PR link: networkservicemesh/sdk#598 networkservicemesh/sdk commit message: commit dae025c5ac5b6d6b8b88957671fb80cffa2e88d8 Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Tue Nov 24 15:46:33 2020 +0700 fix: common/roundrobin: should handle a case if selected endpoint returns error (#598) * fix issue 593 Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> * fix typo Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> * stabilize failing tests Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Nov 24, 2020
…k@master networkservicemesh/sdk#598 networkservicemesh/sdk PR link: networkservicemesh/sdk#598 networkservicemesh/sdk commit message: commit dae025c5ac5b6d6b8b88957671fb80cffa2e88d8 Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Tue Nov 24 15:46:33 2020 +0700 fix: common/roundrobin: should handle a case if selected endpoint returns error (#598) * fix issue 593 Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> * fix typo Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> * stabilize failing tests Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-vpp
that referenced
this pull request
Nov 24, 2020
…k@master networkservicemesh/sdk#598 networkservicemesh/sdk PR link: networkservicemesh/sdk#598 networkservicemesh/sdk commit message: commit dae025c5ac5b6d6b8b88957671fb80cffa2e88d8 Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Tue Nov 24 15:46:33 2020 +0700 fix: common/roundrobin: should handle a case if selected endpoint returns error (#598) * fix issue 593 Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> * fix typo Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> * stabilize failing tests Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-vppagent
that referenced
this pull request
Nov 24, 2020
…k@master networkservicemesh/sdk#598 networkservicemesh/sdk PR link: networkservicemesh/sdk#598 networkservicemesh/sdk commit message: commit dae025c5ac5b6d6b8b88957671fb80cffa2e88d8 Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Tue Nov 24 15:46:33 2020 +0700 fix: common/roundrobin: should handle a case if selected endpoint returns error (#598) * fix issue 593 Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> * fix typo Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> * stabilize failing tests Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Nov 24, 2020
illbegood
pushed a commit
to illbegood/sdk
that referenced
this pull request
Dec 20, 2020
…urns error (networkservicemesh#598) * fix issue 593 Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> * fix typo Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> * stabilize failing tests Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> Signed-off-by: Sergey Ershov <sergey.ershov@xored.com>
illbegood
pushed a commit
to illbegood/sdk
that referenced
this pull request
Dec 20, 2020
…urns error (networkservicemesh#598) * fix issue 593 Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> * fix typo Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> * stabilize failing tests Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> Signed-off-by: Sergey Ershov <sergey.ershov@xored.com>
illbegood
pushed a commit
to illbegood/sdk
that referenced
this pull request
Dec 23, 2020
…urns error (networkservicemesh#598) * fix issue 593 Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> * fix typo Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> * stabilize failing tests Signed-off-by: Denis Tingajkin <denis.tingajkin@xored.com> Signed-off-by: Sergey Ershov <sergey.ershov@xored.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Denis Tingajkin denis.tingajkin@xored.com
Motivation
#597