Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make updatepath set back connection ID on return #603

Merged
merged 1 commit into from
Nov 25, 2020
Merged

Make updatepath set back connection ID on return #603

merged 1 commit into from
Nov 25, 2020

Conversation

Bolodya1997
Copy link

Issue

Updatepath sets new Connection.Id and then returns it back. For the chain element before it looks like:

next.Server(ctx).Request(ctx, request(id-1)) -> connection(id-2)

it is unexpected and confusing.

Solution

Set Connection.Id = Connection.Path.PathSegments[index].Id on updatepath return.

Make updatepath set back connection ID on return, improve tests
3d5e7cf 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
@haiodo haiodo merged commit 146cfff into networkservicemesh:master Nov 25, 2020
nsmbot pushed a commit to networkservicemesh/sdk-vpp that referenced this pull request Nov 25, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
059b48f 
…k@master networkservicemesh/sdk#603

networkservicemesh/sdk PR link: networkservicemesh/sdk#603

networkservicemesh/sdk commit message:
commit 146cfff3a9eca68d8eaa4a76c6f263c070264183
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Wed Nov 25 10:22:06 2020 +0700

    Make updatepath set back connection ID on return, improve tests (#603)

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Nov 25, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
ab91632 
…k@master networkservicemesh/sdk#603

networkservicemesh/sdk PR link: networkservicemesh/sdk#603

networkservicemesh/sdk commit message:
commit 146cfff3a9eca68d8eaa4a76c6f263c070264183
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Wed Nov 25 10:22:06 2020 +0700

    Make updatepath set back connection ID on return, improve tests (#603)

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Nov 25, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
6b72927 
…k@master networkservicemesh/sdk#603

networkservicemesh/sdk PR link: networkservicemesh/sdk#603

networkservicemesh/sdk commit message:
commit 146cfff3a9eca68d8eaa4a76c6f263c070264183
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Wed Nov 25 10:22:06 2020 +0700

    Make updatepath set back connection ID on return, improve tests (#603)

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Nov 25, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
fc36e29 
…k@master networkservicemesh/sdk#603

networkservicemesh/sdk PR link: networkservicemesh/sdk#603

networkservicemesh/sdk commit message:
commit 146cfff3a9eca68d8eaa4a76c6f263c070264183
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Wed Nov 25 10:22:06 2020 +0700

    Make updatepath set back connection ID on return, improve tests (#603)

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-vppagent that referenced this pull request Nov 25, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
0c38524 
…k@master networkservicemesh/sdk#603

networkservicemesh/sdk PR link: networkservicemesh/sdk#603

networkservicemesh/sdk commit message:
commit 146cfff3a9eca68d8eaa4a76c6f263c070264183
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Wed Nov 25 10:22:06 2020 +0700

    Make updatepath set back connection ID on return, improve tests (#603)

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Nov 25, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
41d0552 
…k@master networkservicemesh/sdk#603

networkservicemesh/sdk PR link: networkservicemesh/sdk#603

networkservicemesh/sdk commit message:
commit 146cfff3a9eca68d8eaa4a76c6f263c070264183
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Wed Nov 25 10:22:06 2020 +0700

    Make updatepath set back connection ID on return, improve tests (#603)

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Nov 25, 2020
Merged
Merged
Merged
nsmbot pushed a commit to networkservicemesh/cmd-nse-icmp-responder that referenced this pull request Nov 25, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
10152ff 
…k@master networkservicemesh/sdk#603

networkservicemesh/sdk PR link: networkservicemesh/sdk#603

networkservicemesh/sdk commit message:
commit 146cfff3a9eca68d8eaa4a76c6f263c070264183
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Wed Nov 25 10:22:06 2020 +0700

    Make updatepath set back connection ID on return, improve tests (#603)

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Nov 25, 2020
Merged
Merged
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Nov 25, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
9e2b05c 
…k@master networkservicemesh/sdk#603

networkservicemesh/sdk PR link: networkservicemesh/sdk#603

networkservicemesh/sdk commit message:
commit 146cfff3a9eca68d8eaa4a76c6f263c070264183
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Wed Nov 25 10:22:06 2020 +0700

    Make updatepath set back connection ID on return, improve tests (#603)

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot mentioned this pull request Nov 25, 2020
Merged
illbegood pushed a commit to illbegood/sdk that referenced this pull request Dec 20, 2020
Make updatepath set back connection ID on return, improve tests (netw…
46d321e 
…orkservicemesh#603)

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Signed-off-by: Sergey Ershov <sergey.ershov@xored.com>
illbegood pushed a commit to illbegood/sdk that referenced this pull request Dec 20, 2020
Make updatepath set back connection ID on return, improve tests (netw…
150121e 
…orkservicemesh#603)

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Signed-off-by: Sergey Ershov <sergey.ershov@xored.com>
illbegood pushed a commit to illbegood/sdk that referenced this pull request Dec 23, 2020
Make updatepath set back connection ID on return, improve tests (netw…
9b16782 
…orkservicemesh#603)

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Signed-off-by: Sergey Ershov <sergey.ershov@xored.com>
@Bolodya1997 Bolodya1997 deleted the fix-updatepath branch January 20, 2021 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bolodya1997 @haiodo