Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix metadata #621

Merged
merged 2 commits into from
Dec 8, 2020
Merged

Fix metadata #621

merged 2 commits into from
Dec 8, 2020

Conversation

Bolodya1997
Copy link

Issues

  1. metadata server has some implementation issues
  2. metadata chain elements are not used in common (client, endpoint) chains

Vladimir Popov added 2 commits December 7, 2020 14:47
Fix metadata, add tests
69de06d 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Add metadata chain elements to client, endpoint chains
625898f 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
@Bolodya1997 Bolodya1997 mentioned this pull request Dec 7, 2020
Closed
@haiodo haiodo merged commit f92c817 into networkservicemesh:master Dec 8, 2020
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Dec 8, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
fbb7a79 
…k@master networkservicemesh/sdk#621

networkservicemesh/sdk PR link: networkservicemesh/sdk#621

networkservicemesh/sdk commit message:
commit f92c8177ed69b5d0ece65bf93a8a1404e193e15a
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Tue Dec 8 14:13:01 2020 +0700

    Fix metadata  (#621)

    * Fix metadata, add tests

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

    * Add metadata chain elements to client, endpoint chains

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-vpp that referenced this pull request Dec 8, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
4852435 
…k@master networkservicemesh/sdk#621

networkservicemesh/sdk PR link: networkservicemesh/sdk#621

networkservicemesh/sdk commit message:
commit f92c8177ed69b5d0ece65bf93a8a1404e193e15a
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Tue Dec 8 14:13:01 2020 +0700

    Fix metadata  (#621)

    * Fix metadata, add tests

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

    * Add metadata chain elements to client, endpoint chains

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-icmp-responder that referenced this pull request Dec 8, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c1559c4 
…k@master networkservicemesh/sdk#621

networkservicemesh/sdk PR link: networkservicemesh/sdk#621

networkservicemesh/sdk commit message:
commit f92c8177ed69b5d0ece65bf93a8a1404e193e15a
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Tue Dec 8 14:13:01 2020 +0700

    Fix metadata  (#621)

    * Fix metadata, add tests

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

    * Add metadata chain elements to client, endpoint chains

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Dec 8, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
61f9fec 
…k@master networkservicemesh/sdk#621

networkservicemesh/sdk PR link: networkservicemesh/sdk#621

networkservicemesh/sdk commit message:
commit f92c8177ed69b5d0ece65bf93a8a1404e193e15a
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Tue Dec 8 14:13:01 2020 +0700

    Fix metadata  (#621)

    * Fix metadata, add tests

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

    * Add metadata chain elements to client, endpoint chains

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Dec 8, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
695971a 
…k@master networkservicemesh/sdk#621

networkservicemesh/sdk PR link: networkservicemesh/sdk#621

networkservicemesh/sdk commit message:
commit f92c8177ed69b5d0ece65bf93a8a1404e193e15a
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Tue Dec 8 14:13:01 2020 +0700

    Fix metadata  (#621)

    * Fix metadata, add tests

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

    * Add metadata chain elements to client, endpoint chains

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Dec 8, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
de06d01 
…k@master networkservicemesh/sdk#621

networkservicemesh/sdk PR link: networkservicemesh/sdk#621

networkservicemesh/sdk commit message:
commit f92c8177ed69b5d0ece65bf93a8a1404e193e15a
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Tue Dec 8 14:13:01 2020 +0700

    Fix metadata  (#621)

    * Fix metadata, add tests

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

    * Add metadata chain elements to client, endpoint chains

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-vppagent that referenced this pull request Dec 8, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
436858b 
…k@master networkservicemesh/sdk#621

networkservicemesh/sdk PR link: networkservicemesh/sdk#621

networkservicemesh/sdk commit message:
commit f92c8177ed69b5d0ece65bf93a8a1404e193e15a
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Tue Dec 8 14:13:01 2020 +0700

    Fix metadata  (#621)

    * Fix metadata, add tests

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

    * Add metadata chain elements to client, endpoint chains

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Dec 8, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
f2cc4c4 
…k@master networkservicemesh/sdk#621

networkservicemesh/sdk PR link: networkservicemesh/sdk#621

networkservicemesh/sdk commit message:
commit f92c8177ed69b5d0ece65bf93a8a1404e193e15a
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Tue Dec 8 14:13:01 2020 +0700

    Fix metadata  (#621)

    * Fix metadata, add tests

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

    * Add metadata chain elements to client, endpoint chains

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Dec 8, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@Bolodya1997 Bolodya1997 deleted the _fix-metadata_ branch January 20, 2021 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

@haiodo haiodo haiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bolodya1997 @haiodo @denis-tingaikin