-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refresh should use remote server expiration time for nse #655
Merged
haiodo
merged 1 commit into
networkservicemesh:master
from
denis-tingaikin:fix-refresh-use-remote-time
Jan 15, 2021
Merged
fix: refresh should use remote server expiration time for nse #655
haiodo
merged 1 commit into
networkservicemesh:master
from
denis-tingaikin:fix-refresh-use-remote-time
Jan 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
haiodo
approved these changes
Jan 15, 2021
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder
that referenced
this pull request
Jan 15, 2021
…k@master networkservicemesh/sdk#655 networkservicemesh/sdk PR link: networkservicemesh/sdk#655 networkservicemesh/sdk commit message: commit 5a1a65b5bd4f9f74bfde48e875e33b94c5858d8b Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Fri Jan 15 14:29:44 2021 +0700 refresh should use remote server expiration time for nse (#655) Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Jan 15, 2021
…k@master networkservicemesh/sdk#655 networkservicemesh/sdk PR link: networkservicemesh/sdk#655 networkservicemesh/sdk commit message: commit 5a1a65b5bd4f9f74bfde48e875e33b94c5858d8b Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Fri Jan 15 14:29:44 2021 +0700 refresh should use remote server expiration time for nse (#655) Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Jan 15, 2021
…k@master networkservicemesh/sdk#655 networkservicemesh/sdk PR link: networkservicemesh/sdk#655 networkservicemesh/sdk commit message: commit 5a1a65b5bd4f9f74bfde48e875e33b94c5858d8b Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Fri Jan 15 14:29:44 2021 +0700 refresh should use remote server expiration time for nse (#655) Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Jan 15, 2021
…k@master networkservicemesh/sdk#655 networkservicemesh/sdk PR link: networkservicemesh/sdk#655 networkservicemesh/sdk commit message: commit 5a1a65b5bd4f9f74bfde48e875e33b94c5858d8b Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Fri Jan 15 14:29:44 2021 +0700 refresh should use remote server expiration time for nse (#655) Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Jan 15, 2021
…k@master networkservicemesh/sdk#655 networkservicemesh/sdk PR link: networkservicemesh/sdk#655 networkservicemesh/sdk commit message: commit 5a1a65b5bd4f9f74bfde48e875e33b94c5858d8b Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Fri Jan 15 14:29:44 2021 +0700 refresh should use remote server expiration time for nse (#655) Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Jan 15, 2021
…k@master networkservicemesh/sdk#655 networkservicemesh/sdk PR link: networkservicemesh/sdk#655 networkservicemesh/sdk commit message: commit 5a1a65b5bd4f9f74bfde48e875e33b94c5858d8b Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Fri Jan 15 14:29:44 2021 +0700 refresh should use remote server expiration time for nse (#655) Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Jan 15, 2021
…k@master networkservicemesh/sdk#655 networkservicemesh/sdk PR link: networkservicemesh/sdk#655 networkservicemesh/sdk commit message: commit 5a1a65b5bd4f9f74bfde48e875e33b94c5858d8b Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Fri Jan 15 14:29:44 2021 +0700 refresh should use remote server expiration time for nse (#655) Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Jan 15, 2021
…k@master networkservicemesh/sdk#655 networkservicemesh/sdk PR link: networkservicemesh/sdk#655 networkservicemesh/sdk commit message: commit 5a1a65b5bd4f9f74bfde48e875e33b94c5858d8b Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Fri Jan 15 14:29:44 2021 +0700 refresh should use remote server expiration time for nse (#655) Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-vpp
that referenced
this pull request
Jan 15, 2021
…k@master networkservicemesh/sdk#655 networkservicemesh/sdk PR link: networkservicemesh/sdk#655 networkservicemesh/sdk commit message: commit 5a1a65b5bd4f9f74bfde48e875e33b94c5858d8b Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Fri Jan 15 14:29:44 2021 +0700 refresh should use remote server expiration time for nse (#655) Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-vppagent
that referenced
this pull request
Jan 15, 2021
…k@master networkservicemesh/sdk#655 networkservicemesh/sdk PR link: networkservicemesh/sdk#655 networkservicemesh/sdk commit message: commit 5a1a65b5bd4f9f74bfde48e875e33b94c5858d8b Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Fri Jan 15 14:29:44 2021 +0700 refresh should use remote server expiration time for nse (#655) Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Denis Tingaikin denis.tingajkin@xored.com
Description
If the next of the
refresh
chain element does remote register thenrefresh
doesn't set the expiration time for the response.