-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve registry chains testing with sandbox #668
Improve registry chains testing with sandbox #668
Conversation
40d8d7e
to
5b8e273
Compare
It is not fully correct. You are able to create a registry client using nsmgr url. |
We can add this, but need to think about how to not add more complexity :) |
You are right, it is not making it possible - it reworks general sandbox way to add endpoint to use registry chain :) |
48881d2
to
1f4ec9c
Compare
7386534
to
4b4151e
Compare
c82fd07
to
1afc43c
Compare
54956d7
to
1a3743d
Compare
c11e038
to
9b71b6d
Compare
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
9b71b6d
to
2407767
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@@ -223,7 +223,7 @@ func TestInterdomainFloatingNetworkServiceEndpointRegistry(t *testing.T) { | |||
|
|||
domain3 := sandbox.NewBuilder(t). | |||
SetNodesCount(0). | |||
SetRegistrySupplier(func(context.Context, *url.URL, ...grpc.DialOption) registry2.Registry { | |||
SetRegistrySupplier(func(context.Context, time.Duration, *url.URL, ...grpc.DialOption) registry2.Registry { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we fix the artifact registry2
? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, fixed with registryapi
for github.com/networkservicemesh/api/pkg/api/registry
and no alias for github.com/networkservicemesh/sdk/pkg/registry
.
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
…k@master networkservicemesh/sdk#668 networkservicemesh/sdk PR link: networkservicemesh/sdk#668 networkservicemesh/sdk commit message: commit 64f6aa269f6321844fa3b536ed4793840e918505 Author: Vladimir Popov <vladimir.popov@xored.com> Date: Mon Feb 8 16:28:44 2021 +0700 Improve registry chains testing with sandbox (#668) * Rework sandbox to node API Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Rework tests to the new sandbox Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Add Builder.setupNode Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Cleanup NSEs on context close Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Add sandbox registry client, rework endpoint Register/Unregister Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Rework endpoint registration in sandbox Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Increase default registry expiration Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Use NSE registry client in sandbox Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * NSE should be registered after all NS registered Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Fix imports aliaces Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
…k@master networkservicemesh/sdk#668 networkservicemesh/sdk PR link: networkservicemesh/sdk#668 networkservicemesh/sdk commit message: commit 64f6aa269f6321844fa3b536ed4793840e918505 Author: Vladimir Popov <vladimir.popov@xored.com> Date: Mon Feb 8 16:28:44 2021 +0700 Improve registry chains testing with sandbox (#668) * Rework sandbox to node API Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Rework tests to the new sandbox Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Add Builder.setupNode Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Cleanup NSEs on context close Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Add sandbox registry client, rework endpoint Register/Unregister Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Rework endpoint registration in sandbox Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Increase default registry expiration Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Use NSE registry client in sandbox Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * NSE should be registered after all NS registered Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Fix imports aliaces Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
…k@master networkservicemesh/sdk#668 networkservicemesh/sdk PR link: networkservicemesh/sdk#668 networkservicemesh/sdk commit message: commit 64f6aa269f6321844fa3b536ed4793840e918505 Author: Vladimir Popov <vladimir.popov@xored.com> Date: Mon Feb 8 16:28:44 2021 +0700 Improve registry chains testing with sandbox (#668) * Rework sandbox to node API Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Rework tests to the new sandbox Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Add Builder.setupNode Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Cleanup NSEs on context close Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Add sandbox registry client, rework endpoint Register/Unregister Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Rework endpoint registration in sandbox Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Increase default registry expiration Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Use NSE registry client in sandbox Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * NSE should be registered after all NS registered Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Fix imports aliaces Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
…k@master networkservicemesh/sdk#668 networkservicemesh/sdk PR link: networkservicemesh/sdk#668 networkservicemesh/sdk commit message: commit 64f6aa269f6321844fa3b536ed4793840e918505 Author: Vladimir Popov <vladimir.popov@xored.com> Date: Mon Feb 8 16:28:44 2021 +0700 Improve registry chains testing with sandbox (#668) * Rework sandbox to node API Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Rework tests to the new sandbox Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Add Builder.setupNode Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Cleanup NSEs on context close Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Add sandbox registry client, rework endpoint Register/Unregister Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Rework endpoint registration in sandbox Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Increase default registry expiration Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Use NSE registry client in sandbox Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * NSE should be registered after all NS registered Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Fix imports aliaces Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
…k@master networkservicemesh/sdk#668 networkservicemesh/sdk PR link: networkservicemesh/sdk#668 networkservicemesh/sdk commit message: commit 64f6aa269f6321844fa3b536ed4793840e918505 Author: Vladimir Popov <vladimir.popov@xored.com> Date: Mon Feb 8 16:28:44 2021 +0700 Improve registry chains testing with sandbox (#668) * Rework sandbox to node API Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Rework tests to the new sandbox Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Add Builder.setupNode Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Cleanup NSEs on context close Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Add sandbox registry client, rework endpoint Register/Unregister Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Rework endpoint registration in sandbox Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Increase default registry expiration Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Use NSE registry client in sandbox Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * NSE should be registered after all NS registered Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Fix imports aliaces Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
…k@master networkservicemesh/sdk#668 networkservicemesh/sdk PR link: networkservicemesh/sdk#668 networkservicemesh/sdk commit message: commit 64f6aa269f6321844fa3b536ed4793840e918505 Author: Vladimir Popov <vladimir.popov@xored.com> Date: Mon Feb 8 16:28:44 2021 +0700 Improve registry chains testing with sandbox (#668) * Rework sandbox to node API Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Rework tests to the new sandbox Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Add Builder.setupNode Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Cleanup NSEs on context close Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Add sandbox registry client, rework endpoint Register/Unregister Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Rework endpoint registration in sandbox Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Increase default registry expiration Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Use NSE registry client in sandbox Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * NSE should be registered after all NS registered Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Fix imports aliaces Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
…k@master networkservicemesh/sdk#668 networkservicemesh/sdk PR link: networkservicemesh/sdk#668 networkservicemesh/sdk commit message: commit 64f6aa269f6321844fa3b536ed4793840e918505 Author: Vladimir Popov <vladimir.popov@xored.com> Date: Mon Feb 8 16:28:44 2021 +0700 Improve registry chains testing with sandbox (#668) * Rework sandbox to node API Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Rework tests to the new sandbox Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Add Builder.setupNode Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Cleanup NSEs on context close Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Add sandbox registry client, rework endpoint Register/Unregister Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Rework endpoint registration in sandbox Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Increase default registry expiration Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Use NSE registry client in sandbox Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * NSE should be registered after all NS registered Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Fix imports aliaces Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
…k@master networkservicemesh/sdk#668 networkservicemesh/sdk PR link: networkservicemesh/sdk#668 networkservicemesh/sdk commit message: commit 64f6aa269f6321844fa3b536ed4793840e918505 Author: Vladimir Popov <vladimir.popov@xored.com> Date: Mon Feb 8 16:28:44 2021 +0700 Improve registry chains testing with sandbox (#668) * Rework sandbox to node API Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Rework tests to the new sandbox Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Add Builder.setupNode Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Cleanup NSEs on context close Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Add sandbox registry client, rework endpoint Register/Unregister Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Rework endpoint registration in sandbox Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Increase default registry expiration Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Use NSE registry client in sandbox Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * NSE should be registered after all NS registered Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Fix imports aliaces Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
…k@master networkservicemesh/sdk#668 networkservicemesh/sdk PR link: networkservicemesh/sdk#668 networkservicemesh/sdk commit message: commit 64f6aa269f6321844fa3b536ed4793840e918505 Author: Vladimir Popov <vladimir.popov@xored.com> Date: Mon Feb 8 16:28:44 2021 +0700 Improve registry chains testing with sandbox (#668) * Rework sandbox to node API Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Rework tests to the new sandbox Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Add Builder.setupNode Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Cleanup NSEs on context close Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Add sandbox registry client, rework endpoint Register/Unregister Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Rework endpoint registration in sandbox Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Increase default registry expiration Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Use NSE registry client in sandbox Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * NSE should be registered after all NS registered Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Fix imports aliaces Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Issues
Solution
Rework sandbox to the node API:
Usage: