Discover should use strict name match #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
denis-tingaikin
approved these changes
Feb 1, 2021
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Feb 1, 2021
…k@master networkservicemesh/sdk#687 networkservicemesh/sdk PR link: networkservicemesh/sdk#687 networkservicemesh/sdk commit message: commit eae1be2e20276d6c231307d79937a3cf9002ea1d Author: Vladimir Popov <vladimir.popov@xored.com> Date: Mon Feb 1 13:10:04 2021 +0700 Discover should use strict name match (#687) Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-vpp
that referenced
this pull request
Feb 1, 2021
…k@master networkservicemesh/sdk#687 networkservicemesh/sdk PR link: networkservicemesh/sdk#687 networkservicemesh/sdk commit message: commit eae1be2e20276d6c231307d79937a3cf9002ea1d Author: Vladimir Popov <vladimir.popov@xored.com> Date: Mon Feb 1 13:10:04 2021 +0700 Discover should use strict name match (#687) Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder
that referenced
this pull request
Feb 1, 2021
…k@master networkservicemesh/sdk#687 networkservicemesh/sdk PR link: networkservicemesh/sdk#687 networkservicemesh/sdk commit message: commit eae1be2e20276d6c231307d79937a3cf9002ea1d Author: Vladimir Popov <vladimir.popov@xored.com> Date: Mon Feb 1 13:10:04 2021 +0700 Discover should use strict name match (#687) Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Feb 1, 2021
…k@master networkservicemesh/sdk#687 networkservicemesh/sdk PR link: networkservicemesh/sdk#687 networkservicemesh/sdk commit message: commit eae1be2e20276d6c231307d79937a3cf9002ea1d Author: Vladimir Popov <vladimir.popov@xored.com> Date: Mon Feb 1 13:10:04 2021 +0700 Discover should use strict name match (#687) Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Feb 1, 2021
…k@master networkservicemesh/sdk#687 networkservicemesh/sdk PR link: networkservicemesh/sdk#687 networkservicemesh/sdk commit message: commit eae1be2e20276d6c231307d79937a3cf9002ea1d Author: Vladimir Popov <vladimir.popov@xored.com> Date: Mon Feb 1 13:10:04 2021 +0700 Discover should use strict name match (#687) Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Feb 1, 2021
…k@master networkservicemesh/sdk#687 networkservicemesh/sdk PR link: networkservicemesh/sdk#687 networkservicemesh/sdk commit message: commit eae1be2e20276d6c231307d79937a3cf9002ea1d Author: Vladimir Popov <vladimir.popov@xored.com> Date: Mon Feb 1 13:10:04 2021 +0700 Discover should use strict name match (#687) Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Feb 1, 2021
…k@master networkservicemesh/sdk#687 networkservicemesh/sdk PR link: networkservicemesh/sdk#687 networkservicemesh/sdk commit message: commit eae1be2e20276d6c231307d79937a3cf9002ea1d Author: Vladimir Popov <vladimir.popov@xored.com> Date: Mon Feb 1 13:10:04 2021 +0700 Discover should use strict name match (#687) Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Feb 1, 2021
…k@master networkservicemesh/sdk#687 networkservicemesh/sdk PR link: networkservicemesh/sdk#687 networkservicemesh/sdk commit message: commit eae1be2e20276d6c231307d79937a3cf9002ea1d Author: Vladimir Popov <vladimir.popov@xored.com> Date: Mon Feb 1 13:10:04 2021 +0700 Discover should use strict name match (#687) Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Feb 1, 2021
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Feb 1, 2021
…k@master networkservicemesh/sdk#687 networkservicemesh/sdk PR link: networkservicemesh/sdk#687 networkservicemesh/sdk commit message: commit eae1be2e20276d6c231307d79937a3cf9002ea1d Author: Vladimir Popov <vladimir.popov@xored.com> Date: Mon Feb 1 13:10:04 2021 +0700 Discover should use strict name match (#687) Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Registry doesn't use strict name match for NS, NSE find. Discover can receive NS/NSE with invalid name and pass it further to the chain.
Solution
Make extra name check for NS, NSE on discover.