feat: add nsmlabel tool to help developers build NSCs #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Feb 2, 2021
…k@master networkservicemesh/sdk#691 networkservicemesh/sdk PR link: networkservicemesh/sdk#691 networkservicemesh/sdk commit message: commit 477e672808b4c9d8f89282d0b66f88ff6d87375f Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Tue Feb 2 22:09:19 2021 +0700 add nsmlabel tool (#691) Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Feb 2, 2021
…k@master networkservicemesh/sdk#691 networkservicemesh/sdk PR link: networkservicemesh/sdk#691 networkservicemesh/sdk commit message: commit 477e672808b4c9d8f89282d0b66f88ff6d87375f Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Tue Feb 2 22:09:19 2021 +0700 add nsmlabel tool (#691) Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Feb 2, 2021
…k@master networkservicemesh/sdk#691 networkservicemesh/sdk PR link: networkservicemesh/sdk#691 networkservicemesh/sdk commit message: commit 477e672808b4c9d8f89282d0b66f88ff6d87375f Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Tue Feb 2 22:09:19 2021 +0700 add nsmlabel tool (#691) Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Feb 2, 2021
…k@master networkservicemesh/sdk#691 networkservicemesh/sdk PR link: networkservicemesh/sdk#691 networkservicemesh/sdk commit message: commit 477e672808b4c9d8f89282d0b66f88ff6d87375f Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Tue Feb 2 22:09:19 2021 +0700 add nsmlabel tool (#691) Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder
that referenced
this pull request
Feb 2, 2021
…k@master networkservicemesh/sdk#691 networkservicemesh/sdk PR link: networkservicemesh/sdk#691 networkservicemesh/sdk commit message: commit 477e672808b4c9d8f89282d0b66f88ff6d87375f Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Tue Feb 2 22:09:19 2021 +0700 add nsmlabel tool (#691) Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Feb 2, 2021
…k@master networkservicemesh/sdk#691 networkservicemesh/sdk PR link: networkservicemesh/sdk#691 networkservicemesh/sdk commit message: commit 477e672808b4c9d8f89282d0b66f88ff6d87375f Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Tue Feb 2 22:09:19 2021 +0700 add nsmlabel tool (#691) Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Feb 2, 2021
…k@master networkservicemesh/sdk#691 networkservicemesh/sdk PR link: networkservicemesh/sdk#691 networkservicemesh/sdk commit message: commit 477e672808b4c9d8f89282d0b66f88ff6d87375f Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Tue Feb 2 22:09:19 2021 +0700 add nsmlabel tool (#691) Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-vpp
that referenced
this pull request
Feb 2, 2021
…k@master networkservicemesh/sdk#691 networkservicemesh/sdk PR link: networkservicemesh/sdk#691 networkservicemesh/sdk commit message: commit 477e672808b4c9d8f89282d0b66f88ff6d87375f Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Tue Feb 2 22:09:19 2021 +0700 add nsmlabel tool (#691) Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Feb 2, 2021
…k@master networkservicemesh/sdk#691 networkservicemesh/sdk PR link: networkservicemesh/sdk#691 networkservicemesh/sdk commit message: commit 477e672808b4c9d8f89282d0b66f88ff6d87375f Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Tue Feb 2 22:09:19 2021 +0700 add nsmlabel tool (#691) Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Denis Tingaikin denis.tingajkin@xored.com
Motivation
Currently, cmd-nsc config looks over-designed: https://github.com/networkservicemesh/cmd-nsc/blob/master/internal/config/config.go#L47
Moreover, this approach is not expandable. For building new NSC we need to copy a lot of stuff from cmd-nsc.
We should seek to make things simple.
This PR is the first part of reworking cmd-nsc.