Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sendfd NSE registry client call next Unregister #701

Merged
merged 2 commits into from
Feb 8, 2021
Merged

Make sendfd NSE registry client call next Unregister #701

merged 2 commits into from
Feb 8, 2021

Conversation

Bolodya1997
Copy link

Issue

sendfd NSE registry client doesn't call next Unregister.

Solution

Fix it.

Make sendfd NSE registry client call next Unregister
5978eb3 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
denis-tingaikin
denis-tingaikin approved these changes Feb 7, 2021
View reviewed changes
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

pkg/registry/common/sendfd/client_linux_test.go Show resolved Hide resolved
pkg/registry/common/sendfd/client_linux_test.go Outdated Show resolved Hide resolved
Remove non-needed methods in test type
d884a66 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
@haiodo haiodo merged commit d1280dd into networkservicemesh:master Feb 8, 2021
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Feb 8, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
76c8369 
…k@master networkservicemesh/sdk#701

networkservicemesh/sdk PR link: networkservicemesh/sdk#701

networkservicemesh/sdk commit message:
commit d1280dd2605cb2c5e8b94d13f9b3cf088c3b90a1
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Mon Feb 8 11:01:56 2021 +0700

    Make sendfd NSE registry client call next Unregister (#701)

    * Make sendfd NSE registry client call next Unregister

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

    * Remove non-needed methods in test type

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Feb 8, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
278e515 
…k@master networkservicemesh/sdk#701

networkservicemesh/sdk PR link: networkservicemesh/sdk#701

networkservicemesh/sdk commit message:
commit d1280dd2605cb2c5e8b94d13f9b3cf088c3b90a1
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Mon Feb 8 11:01:56 2021 +0700

    Make sendfd NSE registry client call next Unregister (#701)

    * Make sendfd NSE registry client call next Unregister

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

    * Remove non-needed methods in test type

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Feb 8, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
7ea5dd7 
…k@master networkservicemesh/sdk#701

networkservicemesh/sdk PR link: networkservicemesh/sdk#701

networkservicemesh/sdk commit message:
commit d1280dd2605cb2c5e8b94d13f9b3cf088c3b90a1
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Mon Feb 8 11:01:56 2021 +0700

    Make sendfd NSE registry client call next Unregister (#701)

    * Make sendfd NSE registry client call next Unregister

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

    * Remove non-needed methods in test type

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-icmp-responder that referenced this pull request Feb 8, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c087624 
…k@master networkservicemesh/sdk#701

networkservicemesh/sdk PR link: networkservicemesh/sdk#701

networkservicemesh/sdk commit message:
commit d1280dd2605cb2c5e8b94d13f9b3cf088c3b90a1
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Mon Feb 8 11:01:56 2021 +0700

    Make sendfd NSE registry client call next Unregister (#701)

    * Make sendfd NSE registry client call next Unregister

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

    * Remove non-needed methods in test type

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-vpp that referenced this pull request Feb 8, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d7af211 
…k@master networkservicemesh/sdk#701

networkservicemesh/sdk PR link: networkservicemesh/sdk#701

networkservicemesh/sdk commit message:
commit d1280dd2605cb2c5e8b94d13f9b3cf088c3b90a1
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Mon Feb 8 11:01:56 2021 +0700

    Make sendfd NSE registry client call next Unregister (#701)

    * Make sendfd NSE registry client call next Unregister

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

    * Remove non-needed methods in test type

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Feb 8, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
fe1d5b2 
…k@master networkservicemesh/sdk#701

networkservicemesh/sdk PR link: networkservicemesh/sdk#701

networkservicemesh/sdk commit message:
commit d1280dd2605cb2c5e8b94d13f9b3cf088c3b90a1
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Mon Feb 8 11:01:56 2021 +0700

    Make sendfd NSE registry client call next Unregister (#701)

    * Make sendfd NSE registry client call next Unregister

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

    * Remove non-needed methods in test type

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Feb 8, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
a3b588e 
…k@master networkservicemesh/sdk#701

networkservicemesh/sdk PR link: networkservicemesh/sdk#701

networkservicemesh/sdk commit message:
commit d1280dd2605cb2c5e8b94d13f9b3cf088c3b90a1
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Mon Feb 8 11:01:56 2021 +0700

    Make sendfd NSE registry client call next Unregister (#701)

    * Make sendfd NSE registry client call next Unregister

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

    * Remove non-needed methods in test type

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Feb 8, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
cb82d88 
…k@master networkservicemesh/sdk#701

networkservicemesh/sdk PR link: networkservicemesh/sdk#701

networkservicemesh/sdk commit message:
commit d1280dd2605cb2c5e8b94d13f9b3cf088c3b90a1
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Mon Feb 8 11:01:56 2021 +0700

    Make sendfd NSE registry client call next Unregister (#701)

    * Make sendfd NSE registry client call next Unregister

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

    * Remove non-needed methods in test type

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Feb 8, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
e6a49dd 
…k@master networkservicemesh/sdk#701

networkservicemesh/sdk PR link: networkservicemesh/sdk#701

networkservicemesh/sdk commit message:
commit d1280dd2605cb2c5e8b94d13f9b3cf088c3b90a1
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Mon Feb 8 11:01:56 2021 +0700

    Make sendfd NSE registry client call next Unregister (#701)

    * Make sendfd NSE registry client call next Unregister

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

    * Remove non-needed methods in test type

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Feb 8, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@Bolodya1997 Bolodya1997 deleted the fix-registry-sendfd branch February 12, 2021 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

@haiodo haiodo haiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bolodya1997 @haiodo @denis-tingaikin