Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data race in NSMgr tests #874

Merged

Conversation

Bolodya1997
Copy link

Issue #870.

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
@@ -93,7 +93,11 @@ func (s *nsmgrSuite) Test_Remote_ParallelUsecase() {
request := defaultRequest()
counter := &counterServer{}

var unregisterWG sync.WaitGroup
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we use unregisterED.Wait?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, fixed.

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
@Bolodya1997 Bolodya1997 force-pushed the qfix/race-nsmgr-tests branch from 43d60ec to c065e52 Compare April 27, 2021 05:26
@denis-tingaikin denis-tingaikin merged commit d96382a into networkservicemesh:main Apr 27, 2021
@Bolodya1997 Bolodya1997 deleted the qfix/race-nsmgr-tests branch June 16, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants