Add unit tests for matchutils package #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
d-uzlov
changed the title
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
denis-tingaikin
requested review from
Bolodya1997,
glazychev-art and
Mixaster995
Bolodya1997
approved these changes
Apr 30, 2021
glazychev-art
approved these changes
Apr 30, 2021
denis-tingaikin
approved these changes
Apr 30, 2021
Bolodya1997
pushed a commit
to Bolodya1997/sdk
that referenced
this pull request
Apr 30, 2021
* add tests for matchutils.MatchNetworkServices Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * add tests for matchutils.MatchNetworkServiceEndpoints Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * add tests for matchutils.labelsContains Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * fix matchutils tests using loop variable in a closure Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * fix matchutils copyright header Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * fix matchutils test name Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * disable function length linter for matchutils tests Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
leftovers of cancelled #871 task