[sdk#898] Add clockmock Start #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/tools/clockmock/mock.go
Outdated
| // Start starts mock time to run with the given speed until ctx becomes done. While time is running, current time for | ||
| // the mock will be the following: | ||
| // mock time := mock start time + (real time duration from the start) * speed + mock duration added with Set, Add | ||
| func (m *Mock) Start(ctx context.Context, speed float64) { |
There was a problem hiding this comment.
- Do we need stop method?
- What if Start has called twice?
There was a problem hiding this comment.
- Nope, because we have ctx.
- Time will run with (speed-1 + speed-2) speed :)
There was a problem hiding this comment.
Should this operation be thread-blockable?
There was a problem hiding this comment.
Reworked with always running time and Mock.SetSpeed.
pkg/tools/clockmock/mock.go
Outdated
| m.lock.RLock() | ||
| defer m.lock.RUnlock() | ||
|
|
||
| const tick = 10 * time.Millisecond |
There was a problem hiding this comment.
Should tick be configurable?
There was a problem hiding this comment.
It can, but I can get no usecase why it should.
added 2 commits
May 14, 2021 12:07
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Bolodya1997
force-pushed
the
sdk#898/clock-run-time
branch
2 times, most recently
from
c3b00b5 to
e7a84fc
Compare
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Bolodya1997
force-pushed
the
sdk#898/clock-run-time
branch
from
e7a84fc to
05977b7
Compare
Bolodya1997
requested review from
d-uzlov,
denis-tingaikin,
glazychev-art and
Mixaster995
d-uzlov
approved these changes
May 14, 2021
denis-tingaikin
approved these changes
May 17, 2021
Mixaster995
pushed a commit
to Mixaster995/sdk
that referenced
this pull request
May 17, 2021
* Add clockmock Start Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Fix race issues Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Rework Mock.Start to Mock.SetSpeed Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Mixaster995
pushed a commit
to Mixaster995/sdk
that referenced
this pull request
May 17, 2021
* Add clockmock Start Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Fix race issues Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> * Rework Mock.Start to Mock.SetSpeed Signed-off-by: Vladimir Popov <vladimir.popov@xored.com> Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue link
Relates to #898.
How Has This Been Tested?
Types of changes