Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a high-level description of NSM components #265

Merged
merged 12 commits into from
Dec 6, 2023
Merged

Add a high-level description of NSM components #265

merged 12 commits into from
Dec 6, 2023

Conversation

NikitaSkrynnik
Copy link
Contributor

Issue

#262

@NikitaSkrynnik
Add a high-level description of NSM components
b6cca02 
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
@NikitaSkrynnik
fix some errors
5782f47 
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
@NikitaSkrynnik
change some links
4c5161d 
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
@NikitaSkrynnik
use HTML links
ade5e80 
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
@NikitaSkrynnik
use HTML links
31182d0 
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
@NikitaSkrynnik
cleanup
ccea40d 
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
@NikitaSkrynnik NikitaSkrynnik marked this pull request as ready for review December 4, 2023 08:17
@glazychev-art glazychev-art mentioned this pull request Dec 4, 2023
Open
denis-tingaikin
denis-tingaikin reviewed Dec 4, 2023
View reviewed changes
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments.

Looking promising ;)

content/docs/concepts/components_description.md Outdated Show resolved Hide resolved
content/docs/concepts/components_description.md Outdated Show resolved Hide resolved
content/docs/concepts/components_description.md Outdated Show resolved Hide resolved
content/docs/concepts/components_description.md Outdated Show resolved Hide resolved
content/docs/concepts/components_description.md Outdated Show resolved Hide resolved
content/docs/concepts/components_description.md Outdated Show resolved Hide resolved
content/docs/concepts/components_description.md Outdated Show resolved Hide resolved
content/docs/concepts/components_description.md Outdated Show resolved Hide resolved
content/docs/concepts/components_description.md Outdated Show resolved Hide resolved
content/docs/concepts/components_description.md Outdated Show resolved Hide resolved
@NikitaSkrynnik
apply some review comments
29535db 
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
@NikitaSkrynnik
apply more review comments
04fa913 
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
@NikitaSkrynnik
change images links
9eff334 
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
@denis-tingaikin
Copy link
Member

  1. Headings are too big and do not fit into the table of contents
  2. Reaname Description of NSM components -> NSM components

@NikitaSkrynnik
Change sizes of titles
baac320 
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
glazychev-art
glazychev-art reviewed Dec 6, 2023
View reviewed changes
content/docs/concepts/components_description.md Outdated Show resolved Hide resolved
content/docs/concepts/components_description.md Outdated Show resolved Hide resolved
content/docs/concepts/components_description.md Outdated Show resolved Hide resolved
content/docs/concepts/components_description.md Show resolved Hide resolved
content/docs/concepts/components_description.md Outdated Show resolved Hide resolved
content/docs/concepts/components_description.md Outdated Show resolved Hide resolved
content/docs/concepts/components_description.md Outdated Show resolved Hide resolved
content/docs/concepts/components_description.md Outdated Show resolved Hide resolved
content/docs/concepts/components_description.md Outdated Show resolved Hide resolved
@NikitaSkrynnik
apply review comments
b7554f2 
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
@NikitaSkrynnik
change some words
3e0df73 
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
@denis-tingaikin denis-tingaikin merged commit 19f7d11 into networkservicemesh:main Dec 6, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

@glazychev-art glazychev-art glazychev-art approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NikitaSkrynnik @denis-tingaikin @glazychev-art