Fixed interface_range_expansion with trailing constant #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixed a bug where interface_range_expansion would drop any trailing constant from a range expansion. For instance, `Ethernet[1-3]/1` would expand to `["Ethernet1", "Ethernet2", "Ethernet3"]` without the trailing `/1` fixes networktocode#204
abates
requested review from
itdependsnetworks,
jeffkala and
qduk
as code owners
itdependsnetworks
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request
Have you:
Updated the README if necessary?Updated any configuration settings?Change Notes
This change fixed a bug where interface_range_expansion would drop any trailing constant from a range expansion. For instance,
Ethernet[1-3]/1would expand to["Ethernet1", "Ethernet2", "Ethernet3"]without the trailing/1Justification
Bug fix.