Regex filters #318
Merged
Regex filters #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itdependsnetworks
requested review from
jeffkala,
qduk and
abates
as code owners
jeffkala
approved these changes
Jul 24, 2023
qduk
reviewed
Jul 24, 2023
| "regex_sub": "regex.regex_sub", | ||
| ``` | ||
|
|
||
| These functions will always return a json serializable object and not a complex object like `re.Match` or simialr to better serve the primary use case of functions to be used as Jinja2 filters. After all, they are simply small wrappers around Python `re` functions, the Python provided `re` functionality should be preferred when not using Jinja2 or similar templating language. |
There was a problem hiding this comment.
Suggested change
| These functions will always return a json serializable object and not a complex object like `re.Match` or simialr to better serve the primary use case of functions to be used as Jinja2 filters. After all, they are simply small wrappers around Python `re` functions, the Python provided `re` functionality should be preferred when not using Jinja2 or similar templating language. | |
| These functions will always return a json serializable object and not a complex object like `re.Match` or similar to better serve the primary use case of functions to be used as Jinja2 filters. After all, they are simply small wrappers around Python `re` functions, the Python provided `re` functionality should be preferred when not using Jinja2 or similar templating language. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.