-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Eltex platform with 8 templates #1519
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PavloSkliarenko
requested review from
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
September 10, 2023 22:05
jvanderaa
requested changes
Nov 3, 2023
ntc_templates/templates/eltex_show_interfaces_description.textfsm
Outdated
Show resolved
Hide resolved
ntc_templates/templates/eltex_show_interfaces_switchport.textfsm
Outdated
Show resolved
Hide resolved
Value GATEWAY_STATUS (\S+) | ||
Value GATEWAY_TYPE (\S+) | ||
Value IP (\S+) | ||
Value I_F (.*?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
Value I_F (.*?) | |
Value I_F (.*?) |
Is that an interface? Let's update this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. This is interface. I'll fix it
Co-authored-by: Josh VanDeraa <josh@josh-v.com>
Co-authored-by: Josh VanDeraa <josh@josh-v.com>
Co-authored-by: Josh VanDeraa <josh@josh-v.com>
Co-authored-by: Josh VanDeraa <josh@josh-v.com>
Co-authored-by: Josh VanDeraa <josh@josh-v.com>
Co-authored-by: Josh VanDeraa <josh@josh-v.com>
Fix value names according to new Data model |
jvanderaa
approved these changes
Nov 8, 2023
mjbear
pushed a commit
to mjbear/ntc-templates
that referenced
this pull request
Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Templates for commands:
show interface
show interfaces description
show interfaces status
show interfaces switchport
show ip interface
show system
show system id
show vlan