fix cisco ios show tacacs #1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcn29
requested review from
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
missing new line in yml test file
mjbear
reviewed
Nov 4, 2024
| @@ -24,6 +24,9 @@ Start | |||
| ^\s+Failed\s+Connect\s+Attempts:\s+${FAILED_CONNECTIONS}\s*$$ | |||
| ^\s+Total\s+Packets\s+Sent:\s+${PACKETS_SENT}\s*$$ | |||
| ^\s+Total\s+Packets\s+Recv:\s+${PACKET_RECEIVED}\s*$$ | |||
| ^\s+Server\s+Status:.+?\s*$$ | |||
There was a problem hiding this comment.
Suggested change
| ^\s+Server\s+Status:.+?\s*$$ | |
| ^\s+Server\s+Status:\s+\S+\s*$$ |
From what we have seen at this point there's a space \s+ followed by a word \S+.
trailling space
mjbear
reviewed
Nov 4, 2024
tests/cisco_ios/show_tacacs/cisco_ios_show_tacacs_status_fail_count.yml
Outdated
Show resolved
Hide resolved
regex line 27
mjbear
reviewed
Nov 4, 2024
mjbear
reviewed
Nov 4, 2024
Co-authored-by: Michael Bear <38406045+mjbear@users.noreply.github.com>
mjbear
reviewed
Nov 4, 2024
Co-authored-by: Michael Bear <38406045+mjbear@users.noreply.github.com>
mjbear
reviewed
Nov 4, 2024
tests/cisco_ios/show_tacacs/cisco_ios_show_tacacs_status_fail_count.yml
Outdated
Show resolved
Hide resolved
mjbear
reviewed
Nov 4, 2024
tests/cisco_ios/show_tacacs/cisco_ios_show_tacacs_status_fail_count.raw
Outdated
Show resolved
Hide resolved
…count.raw Co-authored-by: Michael Bear <38406045+mjbear@users.noreply.github.com>
mjbear
reviewed
Nov 4, 2024
tests/cisco_ios/show_tacacs/cisco_ios_show_tacacs_status_fail_count.raw
Outdated
Show resolved
Hide resolved
jmcgill298
reviewed
Nov 4, 2024
…count.raw Co-authored-by: Michael Bear <38406045+mjbear@users.noreply.github.com>
jmcgill298
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In recent IOS XE versions (17.9.x ?), Cisco added 3 new lines in the output of the show tacacs command which are not recognised by the template :
The fix allows the template to recognise and skip those 3 new lines