Created cisco_xr_show_bgp_vrf_all_neighbors_advertised-routes.textfsm

[jorlandobr]

Added new template cisco_xr_show_bgp_vrf_all_neighbors_advertised-routes . Included test case and Index modification.

[mjbear]

I see what you did here, haha.
Hopscotch right to the End once you see a blank line. 😁

[jorlandobr]

Way easier to finish the job :-)

[mjbear]

There is a disadvantage though in that once the first blank line is hit then it goes straight to jail, err End. (Monopoly joke 😆)

I would say jumping to End in this manner may not be desirable though in the long term.

😁 As long as it is ok with @jmcgill298 and the other maintainers then I suppose that's fine.

[jmcgill298]

ya, I'm not sure what this buys us, it seems there is just one more line to catch, so it should be easy enough to look for ^Processed. We will also need to have an ^. -> Error line in this section too. NVM, I just missed that

[mjbear]

Given the syntax on lots of other templates, my $0.02 is not to redirect to end and instead handle the lines.

Allowing this state redirect to End does not align with the project requirement of matching all lines.
I'm wrong, technically the blank line is matched as is Processed.

Is there an advantage of redirecting to End rather than just matching it and being done with the line at that point? I'm inclined to say keep it simple and there's little sense in explicitly redirecting to End.

(Granted there are non-compliant templates from before that project requirement, but those will have to be retroactively identified. Holiday wish list [err, to-do list 😆] of sorts, haha.)

[mjbear]

Looking into it.

[jorlandobr]

How do you generate the YML files from the JSON output? I am using nornir.tech to convert from JSON to YML. But after I have to check cases, spacing...

[mjbear]

@jorlandobr
There are development helper scripts you can use.

I have a fix for the blank entry that I'll be submitting shortly.

[jorlandobr]

The helper scripts, I don't find it. To access them should I use git and download the project to my local machine?

I can't use git at work. Will try this at home.

The blank fix worked!

[mjbear]

The helper scripts, I don't find it. To access them should I use git and download the project to my local machine?

@jorlandobr
Yeah, git clone your fork, switch to your branches where you're developing and run the helper script(s).

I can't use git at work. Will try this at home.

You might be able to use GitHub Codespaces from your browser, but there are "core hours" limits per month based on plans. When you're not using your Codespace, you can stop it here (or delete it when you're done with it).

I was able to get the below to function in case it is of use to you.

# Go to your fork repo and choose the branch you're working on
# Click on the green Code button > Codespaces tab > Create codespace on <branch_name>
# Codespace launches in a new web browser tab

# From the VS Code Terminal
git switch <your_branch_name>
poetry shell
poetry install

# nothing but an example, hehe
python cli.py gen-yaml-folder -f tests/cisco_xr/show_ip_bgp_summary/

💡 Don't forget to conserve your Codespace hours by stopping it here (or delete it when you're done with it).

The blank fix worked!

💯 😁
Yep, thank you, thank you, haha. 🙇

[jmcgill298]

ya, I'm not sure what this buys us, it seems there is just one more line to catch, so it should be easy enough to look for ^Processed. We will also need to have an ^. -> Error line in this section too. NVM, I just missed that

[mjbear]

@jorlandobr
I opened jorlandobr/pull/1 with some test data changes.
Thank you!

This documentation on workflow and branching might be helpful too. It's generally a pain to develop on one's primary branch (ex: master or main are common primary branches).

[jorlandobr]

@jorlandobr I opened jorlandobr/pull/1 with some test data changes. Thank you!

This documentation on workflow and branching might be helpful too. It's generally a pain to develop on one's primary branch (ex: master or main are common primary branches).

Thanks for your help!

I'll start to learn this new tool :-)