Create cisco_asa_show_running-config_object_service #1970
Conversation
wollmannbruno
requested review from
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
ntc_templates/templates/cisco_asa_show_running-config_object_service.textfsm
Outdated
Show resolved
Hide resolved
| Value SRC_PORT_EQ (\S+) | ||
| Value SRC_PORT_GT (\S+) | ||
| Value SRC_PORT_LT (\S+) | ||
| Value SRC_PORT_START (\S+) | ||
| Value SRC_PORT_END (\S+) | ||
| Value DST_PORT_EQ (\S+) | ||
| Value DST_PORT_GT (\S+) | ||
| Value DST_PORT_LT (\S+) | ||
| Value DST_PORT_START (\S+) | ||
| Value DST_PORT_END (\S+) |
There was a problem hiding this comment.
@wollmannbruno
I have some ideas regarding all the port capture groups.
If I work up a PR against your fork would you be willing to review/consider the changes?
I want to make sure my thoughts to simplify align with your expectations/needs/process. Thank you!
There was a problem hiding this comment.
@mjbear
If we can simplify the template, we should.
Send over your changes, and I'll test them against a production firewall.
There was a problem hiding this comment.
@mjbear If we can simplify the template, we should. Send over your changes, and I'll test them against a production firewall.
@wollmannbruno
I created https://github.com/wollmannbruno/ntc-templates/pull/1 for your review.
Since I opened this PR against your fork's obj_service branch, if/when you merge that into that branch it will also be included in this NTC PR.
Thank you! 🙂
…ervice.textfsm Co-authored-by: Michael Bear <38406045+mjbear@users.noreply.github.com>
* Reduce operator-specific capture groups * Support ICMP types and codes
…ervice.textfsm Switch regex from lowercase alphabet to any character other than whitespace. Co-authored-by: Bruno Wollmann <bruno@terra-comm.ca>
…service.raw Co-authored-by: Bruno Wollmann <bruno@terra-comm.ca>
Co-authored-by: Bruno Wollmann <bruno@terra-comm.ca>
Simplify structured data and add support for operators and ICMP
This PR resolves issue #1968.