Remove "terminal" dependency #672
Merged
+2
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcgill298
reviewed
Apr 30, 2020
There was a problem hiding this comment.
If we set the version of TextFSM, then we should also remove the try/except block here:
ntc-templates/lib/ntc_templates/parse.py
Lines 4 to 7 in fb64024
|
You want me to make that edit in this PR also (the parse.py multiple import edit--for old/new textfsm)? |
|
That would be great. Thanks |
|
Sounds good. Will update. |
|
Thanks @ktbyers |
thomasblass
pushed a commit
to thomasblass/ntc-templates
that referenced
this pull request
Oct 25, 2020
* Eliminate terminal dependency * Fix imports to use only textfsm >=1.1
jvanderaa
pushed a commit
that referenced
this pull request
Nov 10, 2021
* Eliminate terminal dependency * Fix imports to use only textfsm >=1.1
guillaume-mbali
pushed a commit
to unyc-io/ntc-templates
that referenced
this pull request
Apr 12, 2023
* Eliminate terminal dependency * Fix imports to use only textfsm >=1.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a long-standing issue in TextFSM which caused textfsm to break on Windows. This was due to the TextFSM library importing the "fcntl" library (inside TextFSM's terminal.py module).
ntc-templates had a workaround for this problem where they installed a completely different
terminallibrary.This worked in textfsm 0.4.1 as textfsm_0_4_1 would put all of its Python files directly into site-packages (literally ./site-packages/terminal.py). Consequently, the install of the other
terminalmodule would overwrite theterminal.pythat came installed with textfsm.With this fix here:
https://github.com/google/textfsm/blob/v1.1.1/textfsm/terminal.py#L25-L29
And with the fact that textfsm is now installed as a proper package in site-packages (in other words
site-packages/textfsm/and then the package files inside that directory).The installation of the other
terminalpackage should now be useless.The relevance to me is that I am interested in making ntc-templates a direct Netmiko dependency, but I don't really like installing this separate terminal.py file (https://github.com/lepture/terminal) as that library is unmaintained (last commit in 2013)
Additionally, I have had interoperability issues with the ntc-templates fix to this problem in the paste. And now that it is obsolete, it would be good to get rid of it.
There is no code that is actually by in terminal.py by ntc-templates or Netmiko (in either the old or the new solution). The problem is entirely an import issue.