Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can not install schema-enforcer in environments which require a version of jsonschema < 4.6 #141

Closed
PhillSimonds opened this issue Jul 25, 2022 · 1 comment · Fixed by #142
Closed

Can not install schema-enforcer in environments which require a version of jsonschema < 4.6 #141

PhillSimonds opened this issue Jul 25, 2022 · 1 comment · Fixed by #142

Comments

@PhillSimonds
Copy link
Contributor

PhillSimonds commented Jul 25, 2022 •
edited
Loading

Environment

  • Python version: 3.7.10
  • schema-enforcer version: 1.1.4

Expected Behavior

I expected to be able to install schema-enforcer in an environment where the jsonschema library could be anything > 3.2 and <5.

Observed Behavior

When the version of jsonschema installed is < 4.6, the format-nongpl extra can't be found.

This looks to be because format_nongpl was changed to format-nongpl in jsonschema 4.6.

python-jsonschema/jsonschema#962
@PhillSimonds PhillSimonds changed the title Can not install schema-enforcer in environments which require a version of jsonschema < 4.7 Can not install schema-enforcer in environments which require a version of jsonschema < 4.6 Jul 25, 2022
@PhillSimonds PhillSimonds mentioned this issue Jul 25, 2022
Merged
@PhillSimonds PhillSimonds mentioned this issue Jul 27, 2022
Merged
@PhillSimonds
Copy link
Contributor Author

We decided to remediate this issue by provisioning two releases of schema-enforcer

  1. v1.1.5 supports versions of jsonschema <4.5 and allows for installation of the format_nongpl extra
  2. v1.2.0 supports versions of jsonschema >=4.6 and allows for installation of the format-nongpl extra

@PhillSimonds PhillSimonds mentioned this issue Jul 27, 2022
Merged
PhillSimonds added a commit that referenced this issue Jul 27, 2022
@PhillSimonds
Merge pull request #143 from networktocode/develop
52848ce 
v1.1.5 Release

### Changes

- Fixes #141 - Can not install schema-enforcer in environments which require a version of jsonschema < 4.6
@PhillSimonds PhillSimonds mentioned this issue Jul 27, 2022
Merged
@PhillSimonds PhillSimonds mentioned this issue Jun 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prep for v1.1.5 release networktocode/schema-enforcer
1 participant
@PhillSimonds