This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Update http output plugin to ignore 409 response code #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to track the changes/fixes made in the branch fix-http-output-1.19.2 to the http output plugin.
This change was made as a temporary fix to allow Telegraf to remote-write data into Thanos using the HTTP output plugin.
By design Thanos will return a 409 when some data can't be ingested for various reasons and the client should drop these metrics. Without this fix, Telegraf will try to resend all data after receiving a 409 response code, which blocks all data to be send to Thanos until the faulty block expires.