drivers/liebert-gxe.c: fix bad backup time report #2751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodspeed34
force-pushed
the
gxe-bad-runtime
branch
2 times, most recently
from
a4fdbf8 to
78805a1
Compare
It seems `battery.runtime` should be used for battery backup time instead `.low` one. Also the division was also faulty probably because I copied and pasted the code from previous lines but the manual says it shouldn't be there. The commit should give correct backup time readings and corrected variable name. Signed-off-by: Gong Zhile <gongzl@stu.hebust.edu.cn>
goodspeed34
force-pushed
the
gxe-bad-runtime
branch
from
78805a1 to
518c527
Compare
jimklimov
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems
battery.runtimeshould be used for battery backup time instead of.lowone. Also the division was also faulty probably because I copied and pasted the code from previous lines but the manual says it shouldn't be there.The commit should give correct backup time readings and corrected variable name.
Follow-up from: #2629 and #2669