Fix make memcheck
#2785
Merged
Fix make memcheck
#2785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…e the helper script a template Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
… option Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…NIT leaky internals) Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…opened DIRFD Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…ix memory leak with temporary BoolInt instances Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…o avoid use after free Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
… which we did not upsdrv_init() Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…T coding style Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…once Check if (gpioupsfd!=NULL) and nullify it afterwards. Should not be a problem in the real driver, but confused the repetitive use of this code in unit test case. Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…o occasionally repeat the attempt Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…cal->rules) itself too, not just entries in the list Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…or generic_gpio_close() to take a pointer to pointer and nullify it Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…code is freed before we (re?)init it in test Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…mize * Less lookups to testval/getval * Do not xalloc and fatalx if got no rules (avoid leak) Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
… driver code is freed before we (re?)init it in test" This reverts commit bf59f10. Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…TOOL values Signed-off-by: Jim Klimov <jimklimov@gmail.com>
jimklimov
added
bug
C++
GPIO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up from #2781
Some fixes are for valgrind suppression rules to not complain about CPPUNIT per se, others are actual bugs found in code.