Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT : added lint workflow test #28

Merged
merged 8 commits into from
Jan 23, 2024
Merged

MAINT : added lint workflow test #28

merged 8 commits into from
Jan 23, 2024

Conversation

Schefflera-Arboricola
Copy link
Member

@Schefflera-Arboricola Schefflera-Arboricola commented Jan 3, 2024 •
edited
Loading

added lint.yml

@Schefflera-Arboricola Schefflera-Arboricola marked this pull request as draft January 3, 2024 18:08
@Schefflera-Arboricola Schefflera-Arboricola marked this pull request as ready for review January 4, 2024 14:47
dschult
dschult approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it works. Did the linting tell us to change type to isinstance and to shorten the line in the doc_string? Or are those changes we need for other reasons?

I approve this PR no matter what the answers to those questions are. :)

@Schefflera-Arboricola
Copy link
Member Author

Did the linting tell us to change type to isinstance and to shorten the line in the doc_string?

yes

Also, should I add some more tests to this pr?

Thanks!

@dschult
Copy link
Member

dschult commented Jan 5, 2024

If the additional tests are linting related add them here -- otherwise it also makes sense to add them separately. That way it is easier to review the PRs.

@Schefflera-Arboricola Schefflera-Arboricola changed the title adding workflow tests added lint workflow test Jan 6, 2024
@Schefflera-Arboricola
Copy link
Member Author

Schefflera-Arboricola commented Jan 6, 2024 •
edited
Loading

I think we can add more tests in future.

@Schefflera-Arboricola Schefflera-Arboricola changed the title added lint workflow test MAINT : added lint workflow test Jan 11, 2024
@MridulS MridulS merged commit ff625b8 into networkx:main Jan 23, 2024
11 checks passed
@jarrodmillman jarrodmillman added this to the 0.1 milestone Jan 23, 2024
@jarrodmillman jarrodmillman modified the milestones: 0.1, 0.2 May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschult dschult dschult approved these changes

Assignees
No one assigned
Labels
type: Maintenance
Milestone
0.2
Development

Successfully merging this pull request may close these issues.
4 participants
@Schefflera-Arboricola @dschult @jarrodmillman @MridulS