Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH, BUG] : added time_tournament_is_strongly_connected benchmark, renamed tournament_is_strongly_connected to is_strongly_connected #32

Merged
merged 4 commits into from
Mar 26, 2024

Conversation

Schefflera-Arboricola
Copy link
Member

@Schefflera-Arboricola Schefflera-Arboricola commented Jan 15, 2024

Please do "Squash and merge" while merging this PR

  1. added time_tournament_is_strongly_connected benchmark
  2. renamed tournament_is_strongly_connected to is_strongly_connected in tournament.py and then assigned tournament_is_strongly_connected = is_strongly_connected in Dispatcher class, like how it's done in the main networkx repo(origin ENH : Adding backend_info entry point #27)
>>> import nx_parallel as nxp
>>> import networkx as nx
>>> G = nx.tournament.random_tournament(50, seed=42)
>>> nx.tournament.is_strongly_connected(G)
True

Before :

>>> nxp.tournament.is_strongly_connected(G)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: module 'nx_parallel.algorithms.tournament' has no attribute 'is_strongly_connected'

After :

>>> nxp.tournament.is_strongly_connected(G)
True

@Schefflera-Arboricola Schefflera-Arboricola changed the title added time_tournament_is_strongly_connected benchmark ENH : added time_tournament_is_strongly_connected benchmark Jan 19, 2024
@dschult dschult added the type: Enhancement New feature or request label Jan 31, 2024
@Schefflera-Arboricola Schefflera-Arboricola changed the title ENH : added time_tournament_is_strongly_connected benchmark [ENH, BUG] : added time_tournament_is_strongly_connected benchmark, renamed tournament_is_strongly_connected to is_strongly_connected Feb 1, 2024
@Schefflera-Arboricola
Copy link
Member Author

The failed test should pass after a re-run.
fixed @ networkx/networkx#7264

@dschult dschult merged commit fdcd632 into networkx:main Mar 26, 2024
11 checks passed
@jarrodmillman jarrodmillman added this to the 0.1 milestone Mar 26, 2024
@jarrodmillman jarrodmillman modified the milestones: 0.1, 0.2 May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: Enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants