Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH : added square_clustering #34

Merged
merged 16 commits into from
Mar 10, 2024

Conversation

Schefflera-Arboricola
Copy link
Member

@Schefflera-Arboricola Schefflera-Arboricola commented Jan 18, 2024

Please do "Squash and merge" while merging this PR

@Schefflera-Arboricola Schefflera-Arboricola marked this pull request as draft January 18, 2024 21:21
@Schefflera-Arboricola Schefflera-Arboricola changed the title added square_clustering ENH : added square_clustering Jan 19, 2024
@Schefflera-Arboricola Schefflera-Arboricola marked this pull request as ready for review January 19, 2024 19:10
Copy link
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.
Any surprises in doing this one? It looks like it was just a matter of taking out the guts of a for loop and wrapping that in joblib.

The benchmark is nice too. :}

@dschult dschult added the type: Enhancement New feature or request label Jan 30, 2024
Copy link
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR is ready. You'll need to rebase on main into it to get passed the style test (Here's a description of how to rebase.

Copy link
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM!

@dschult dschult merged commit 882646b into networkx:main Mar 10, 2024
11 checks passed
@jarrodmillman jarrodmillman added this to the 0.1 milestone Mar 10, 2024
@jarrodmillman jarrodmillman modified the milestones: 0.1, 0.2 May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: Enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants