-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH : added square_clustering
#34
ENH : added square_clustering
#34
Conversation
square_clustering
square_clustering
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
Any surprises in doing this one? It looks like it was just a matter of taking out the guts of a for loop and wrapping that in joblib.
The benchmark is nice too. :}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR is ready. You'll need to rebase on main into it to get passed the style test (Here's a description of how to rebase.
7eb5c61
to
5e9c645
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM!
Please do "Squash and merge" while merging this PR