Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconfigure so ParallelGraph stores original nx graph #9

Merged
merged 42 commits into from
Oct 5, 2023

Conversation

dschult
Copy link
Member

@dschult dschult commented Sep 13, 2023

configure ParallelGraph so that it just stores the origin graph as an attribute.

Also need is_directed and is_multigraph to call the stored graphs methods.
clean up the linting and testing workflows, pre-commits, pyproject.toml

20kavishs and others added 30 commits June 27, 2023 00:32
isolates passes all tests
still need to pass a few betweenness tests
…tality and tournament

- Decided to just make things work with PR #6688 (had all the functions I needed marked with dispatch decorator)
- More graph types and small interface changes
- parallel implementations of closeness_vitality + tournament (I am a bit ahead of schedule)
- Made networkx tests into my own tests for nx_parallel (same directories as in networkx. can be easily run w pytest for CI)
- ended up having to include all the functions, but didn't have to reimplement (see isolates or tournament for example)
- added utils/chunk.py
- Fixed betweenness tests, had some small errors in them
- Minor changes to graph class constructors
- Changed betweenness_centrality implementation, passes all tests
Redid betweenness without convert function

Tried to use __wrapped__ but it only worked for isolates...for consistency I kept everything the same

Errors for using __wrapped__ were because various methods were "not implemented by parallel"
added originalGraph to parallel classes, added heatmaps + their code in the timing folder

WIP for heatmap
@dschult
Copy link
Member Author

dschult commented Sep 18, 2023

The test failures here come about from having a different number of chunks than local tests. I'm working on a system for testing which would allow setting of the number of chunks. The obvious problem of 1 chunk vs >1 chunk is most important to test, but other values might be helpful too.

@dschult dschult merged commit 315f433 into networkx:main Oct 5, 2023
6 checks passed
@dschult dschult deleted the store_graph branch October 5, 2023 00:37
@jarrodmillman jarrodmillman added the type: Enhancement New feature or request label Oct 13, 2023
@jarrodmillman jarrodmillman added this to the 0.1 milestone Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: Enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants