-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconfigure so ParallelGraph stores original nx graph #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isolates passes all tests still need to pass a few betweenness tests
…tality and tournament - Decided to just make things work with PR #6688 (had all the functions I needed marked with dispatch decorator) - More graph types and small interface changes - parallel implementations of closeness_vitality + tournament (I am a bit ahead of schedule) - Made networkx tests into my own tests for nx_parallel (same directories as in networkx. can be easily run w pytest for CI) - ended up having to include all the functions, but didn't have to reimplement (see isolates or tournament for example) - added utils/chunk.py
- Fixed betweenness tests, had some small errors in them - Minor changes to graph class constructors - Changed betweenness_centrality implementation, passes all tests
Redid betweenness without convert function Tried to use __wrapped__ but it only worked for isolates...for consistency I kept everything the same Errors for using __wrapped__ were because various methods were "not implemented by parallel"
Passes all tests
added originalGraph to parallel classes, added heatmaps + their code in the timing folder WIP for heatmap
The test failures here come about from having a different number of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configure ParallelGraph so that it just stores the origin graph as an attribute.
Also need
is_directed
andis_multigraph
to call the stored graphs methods.clean up the linting and testing workflows, pre-commits, pyproject.toml