Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate image assets to cdn.netz39.de #140

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Migrate image assets to cdn.netz39.de #140

merged 2 commits into from
Dec 19, 2024

Conversation

teuserer
Copy link
Contributor

@teuserer teuserer commented Nov 5, 2024

Dieser PR ist abhängig von penguineer/cdn.netz39.de#4

Die Gallerie ist hiermit leer. https://www.netz39.de/gallery/
Sie scheint aber auch nicht genutzt worden zu sein.

@teuserer teuserer changed the title insert cdn domain into all assets/img/ urls Migrate image assets to cdn.netz39.de Nov 5, 2024
@teuserer teuserer linked an issue Nov 5, 2024 that may be closed by this pull request
Das GitHub LFS Quota ist nicht ausreichend #137
Closed
AOphagen
AOphagen approved these changes Dec 12, 2024
View reviewed changes
Copy link

@AOphagen AOphagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passt.

AOphagen
AOphagen approved these changes Dec 12, 2024
View reviewed changes
Copy link

@AOphagen AOphagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nein, ich habe nicht alle 354 Dateien einzeln angeschaut, aber den Anfang, das Ende und einige Stichproben. Passt.

penguineer
penguineer requested changes Dec 12, 2024
View reviewed changes
Copy link
Member

@penguineer penguineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sehe ich richtig, dass Du vor allem die URL-Pattern angepasst hast? Ich sehe in der ersten URL schon ein 404 - bitte nochmal prüfen, ob da ggf. zu viel geändert wurde.

@penguineer penguineer requested review from MG-5 and timherrm December 18, 2024 21:46
MG-5
MG-5 approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@MG-5 MG-5 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stichpunktartige Proben sahen gut aus

@MG-5 MG-5 merged commit 41506d8 into main Dec 19, 2024
1 check passed
@MG-5 MG-5 deleted the feat/cdn branch December 19, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penguineer penguineer penguineer requested changes

@AOphagen AOphagen AOphagen approved these changes

@MG-5 MG-5 MG-5 approved these changes

@timherrm timherrm Awaiting requested review from timherrm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Das GitHub LFS Quota ist nicht ausreichend
4 participants
@teuserer @penguineer @AOphagen @MG-5