Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump captainhook/captainhook from 5.17.3 to 5.18.0 #1321

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 10, 2023

Bumps captainhook/captainhook from 5.17.3 to 5.18.0.

Release notes

Sourced from captainhook/captainhook's releases.

5.18.0

Changes

  • Improve run configuration fixes issue #178 big thanks to @​renky
  • Improve a bunch of types

If you use Docker to execute the captain until now you could run into problems by using git commit -a. The reason being that git uses an environment variable to configure the index file to use. The command git commit -a creates a new index file with everything in in it not changing your original index before the command succeeds.

So for this to work, the GIT_INDEX_FILE environment variable hat to be forwarded to the Docker container. And more, since the variable contains the path to the index file the path had to be mapped from the host system path to the container path.

This is now all done by the Capn, but only if you specify the run-gitconfig value with the path to the.git` directory within your container.

Here is an example configuration:

{
  "config": {
    "run": {
      "mode": "docker",
      "exec": "docker exec my-container",
      "path": "vendor/bin/captainhook",
      "git": "/docker/mx-project/.git"
    }
  }
  ...
}

For hooks that could need the environment variable like pre-commit this will result in Docker command like this:

docker exec -i -e GIT_INDEX_FILE=/docker/my-project/.git/($GIT_INDEX_FILE) my-container vendor/bin/captainhook ...

So from version 5.18.0 the Cap`n tries to optimize you docker commands. If you run in any problems let me know.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [captainhook/captainhook](https://github.com/captainhookphp/captainhook) from 5.17.3 to 5.18.0.
- [Release notes](https://github.com/captainhookphp/captainhook/releases)
- [Commits](captainhookphp/captainhook@5.17.3...5.18.0)

---
updated-dependencies:
- dependency-name: captainhook/captainhook
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file php Pull requests that update Php code labels Oct 10, 2023
@github-actions
Copy link

Download the artifacts for this pull request:

@cmuench cmuench merged commit f684cb3 into develop Oct 11, 2023
15 checks passed
@dependabot dependabot bot deleted the dependabot/composer/captainhook/captainhook-5.18.0 branch October 11, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant