Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SQL definer replacement optional #1348

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

p-makowski
Copy link
Contributor

@p-makowski p-makowski commented Nov 22, 2023

Magerun pull-request check-list:

  • Pull request against develop branch (if not, just close and create a new one against it)
  • README.md reflects changes (if any)
  • phar fuctional test (in tests/phar-test.sh)

Summary:
Even when magerun db dump command is executed with --only-command option a piped definer replacement is added to its output. In some scenarios it is a bit not intuitive or undesirable, e.g. when dump is imported on the same database or --only-command output is further processed in separate script.

Changes proposed in this pull request:

  • Added flag keep-definer to allow a pure mysql command to be outputted or executed.

@cmuench cmuench merged commit b685e7e into netz98:develop Nov 28, 2023
13 of 14 checks passed
@cmuench
Copy link
Member

cmuench commented Nov 28, 2023

@p-makowski Hi my old friend :-)
Thanks for contributing.

@p-makowski
Copy link
Contributor Author

Thanks @cmuench
Long time no see! I hope to be your guest more often here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants