Skip to content
This repository has been archived by the owner on Sep 22, 2024. It is now read-only.

debug(components): inject single island bundle #131

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Conversation

miguelrk
Copy link
Contributor

This is an attempt to fix deployment issue due to missing _app.tsx.

@miguelrk
Copy link
Contributor Author

miguelrk commented Feb 14, 2024

Based on the tests/investigation here, I'll merge and release 0.4.38 to test this if we can get away without having to require an _app.tsx for the minimal template (it works locally, but might fail in deployment).

If this does not resolve https://github.com/netzo/netzo/issues/130, I'll release a hotfix patch release 0.4.39 with a local @/islands/layout.tsx file which simply does export * from "netzo/components/layout/mod.ts"; instead of dynamically injecting the islands via the plugin. Note that the @/islands/layout.tsx file should only be added to the crm template which has an _app.tsx.

Update: 0.4.38 did not solve this, proceeding with aforementioned 0.4.39

@miguelrk miguelrk merged commit 09faf17 into main Feb 14, 2024
1 check passed
@miguelrk miguelrk deleted the fix-layout-issues branch February 14, 2024 13:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant