Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(login): ignore timeout error in commit 69899c0f795ebc518bcdd151e758dae973ad1cc0 #50

Closed
wants to merge 1 commit into from

Conversation

bsbds
Copy link
Contributor

@bsbds bsbds commented May 30, 2022

实在抱歉,之前的开pr草率了,因为之前一直用的无线校园网,今天连学校有线网络的时候才意识到有问题

原因如下:
我发现有线校园网不会自动重定向http请求,在有线校园网下 commit 69899c0 对不存在服务器发出请求一定会timeout直接返回err,导致后面的登录流程不能进行

这个pr改为不返回err,但是连有线网会出现等待timeout几秒的副作用,所以只是一个workaround,不知道有没有更好的解决方法

@unbyte
Copy link
Member

unbyte commented May 31, 2022

一些思路:

  1. 只有http请求才能解决 无网络请求的时候登录失败 #48
  2. 如果是,那么发送请求而不等待响应可以解决 无网络请求的时候登录失败 #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants